Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-native): enable hermes engine #15279

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Calinteodor
Copy link
Contributor

No description provided.

@Calinteodor Calinteodor marked this pull request as draft November 7, 2024 08:17
ios/Podfile.lock Outdated Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven' t found any security related issues.

Image of Satya Satya


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard

@Calinteodor Calinteodor force-pushed the enable-hermes-engine branch 2 times, most recently from e4de48b to a532a16 Compare November 22, 2024 11:02
@Calinteodor Calinteodor changed the title W.I.P. chore(react-native): enable hermes engine chore(react-native): enable hermes engine Nov 22, 2024
@Calinteodor Calinteodor marked this pull request as ready for review November 22, 2024 11:33
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Left some comments, PTAL. Please rebase with master too, so the new SDK CI tests run.

You can also have some stuff to delete:

  • The part which pushes the JSC library to maven, in the android release-sdk.sh script

android/app/build.gradle Outdated Show resolved Hide resolved
android/app/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Show resolved Hide resolved
android/gradle.properties Outdated Show resolved Hide resolved
android/gradle.properties Outdated Show resolved Hide resolved
ios/Podfile Outdated Show resolved Hide resolved
ios/app/app.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
android/sdk/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants