Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Relax the health checks for STUN #2077

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Dec 20, 2023

By default only fail when there is no valid address for ICE. Put the
option to require STUN behind a flag.

By default only fail when there is no valid address for ICE. Put the
option to require STUN behind a flag.
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (719465d) 43.98% compared to head (207ad1f) 43.98%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2077      +/-   ##
============================================
- Coverage     43.98%   43.98%   -0.01%     
+ Complexity     1918     1917       -1     
============================================
  Files           340      340              
  Lines         18881    18895      +14     
  Branches       2593     2595       +2     
============================================
+ Hits           8305     8311       +6     
- Misses         9724     9732       +8     
  Partials        852      852              
Files Coverage Δ
...rg/jitsi/videobridge/health/config/HealthConfig.kt 100.00% <100.00%> (ø)
...n/org/jitsi/videobridge/health/JvbHealthChecker.kt 34.78% <0.00%> (-18.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719465d...207ad1f. Read the comment docs.

@bgrozev bgrozev merged commit e41cad1 into jitsi:master Dec 21, 2023
3 of 5 checks passed
@bgrozev bgrozev deleted the relax-health-checks-for-stun branch May 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants