Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Move Harvesters to kotlin. #2081

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jan 19, 2024

No description provided.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (b2d4229) 0.00% compared to head (f9c4ad3) 43.99%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2081       +/-   ##
=============================================
+ Coverage          0   43.99%   +43.99%     
- Complexity        0     1919     +1919     
=============================================
  Files             0      340      +340     
  Lines             0    18881    +18881     
  Branches          0     2590     +2590     
=============================================
+ Hits              0     8307     +8307     
- Misses            0     9725     +9725     
- Partials          0      849      +849     
Files Coverage Δ
...rg/jitsi/videobridge/transport/ice/IceTransport.kt 25.92% <50.00%> (ø)
jvb/src/main/kotlin/org/jitsi/videobridge/Main.kt 0.00% <0.00%> (ø)
...n/org/jitsi/videobridge/health/JvbHealthChecker.kt 34.78% <0.00%> (ø)
...ain/kotlin/org/jitsi/videobridge/ice/Harvesters.kt 26.66% <26.66%> (ø)

... and 336 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d4229...f9c4ad3. Read the comment docs.

Harvesters.initializeStaticConfiguration()

// Initialize, binding on the main ICE port.
Harvesters.INSTANCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this constructs the object and thus does the static initialization, but it still feels weird idiomatically to just reference an object and not use it. Is there any way to make this look like a function call without making other things less idiomatic?

@bgrozev bgrozev merged commit 57abe58 into jitsi:master Jan 23, 2024
5 checks passed
@bgrozev bgrozev deleted the refactor-harvesters branch May 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants