Add a Java option to work around a major performance regression in JDK 17 #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…K 17. There was a rewrite of the Java networking stack in Java 13 which made it impossible to concurrently send UDP from multiple threads on the same DatagramSocket. See https://bugs.openjdk.org/browse/JDK-8303616. This Java option causes Java to use its old DatagramSocket implementation. Note that unfortunately this workaround does not work in Java 18 and later.
damencho
approved these changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2110 +/- ##
=========================================
Coverage 44.22% 44.22%
Complexity 1939 1939
=========================================
Files 340 340
Lines 18906 18906
Branches 2612 2612
=========================================
Hits 8361 8361
Misses 9676 9676
Partials 869 869 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a rewrite of the Java networking stack in Java 13 which made it impossible to concurrently send UDP from multiple threads on the same DatagramSocket. See https://bugs.openjdk.org/browse/JDK-8303616. This Java option causes Java to use its old DatagramSocket implementation.
Note that unfortunately this workaround does not work in Java 18 and later.