Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(dcsctp): Allow unlimited sctp retransmissions with dcsctp. #2180

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix(dcsctp): Allow unlimited sctp retransmissions with dcsctp. #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion jvb/src/main/kotlin/org/jitsi/videobridge/dcsctp/DcSctpTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ class DcSctpTransport(
check(SctpConfig.config.enabled()) { "SCTP is disabled in configuration" }
DcSctpOptions().apply {
maxTimerBackoffDuration = DEFAULT_MAX_TIMER_DURATION
// Because we're making retransmits faster, we need to allow unlimited retransmits
// or SCTP can time out (which we don't handle). Peer connection timeouts are handled at
// a higher layer.
maxRetransmissions = null
maxInitRetransmits = null
}
}

Expand Down Expand Up @@ -127,7 +132,9 @@ abstract class DcSctpBaseCallbacks(
}

override fun OnStreamsResetPerformed(outgoingStreams: ShortArray) {
transport.logger.info("Surprising SCTP callback: outgoing streams ${outgoingStreams.joinToString()} reset")
// This is normal following a call to close(), which is a hard-close (as opposed to shutdown() which is
// soft-close)
transport.logger.info("Outgoing streams ${outgoingStreams.joinToString()} reset")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useful at info?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sctp info logs are probably a bit chatty at this point, but that can be revisited later

}

override fun OnIncomingStreamsReset(incomingStreams: ShortArray) {
Expand Down
Loading