Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add required events dependency for browser environments #1841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sapkra
Copy link
Contributor

@sapkra sapkra commented Jan 10, 2022

Currently lib-jitsi-meet imports events but it's not defined in the package.json. The IDE thinks it imports the built-in module of node.js but webpack actually resolves it as the events package which is installed as a dependency of webpack itself. This PR clarifies which module is actually imported.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@sapkra sapkra added the bug Generic issue label Jan 10, 2022
@saghul
Copy link
Member

saghul commented Jan 11, 2022

Jenkins please test this please.

@saghul
Copy link
Member

saghul commented Mar 8, 2022

OOps, sorry this one got lost, can you PL rebase?

Abhishek260305 added a commit to Abhishek260305/lib-jitsi-meet that referenced this pull request May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Generic issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants