Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation improved #2583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

documentation improved #2583

wants to merge 2 commits into from

Conversation

hxrshxz
Copy link

@hxrshxz hxrshxz commented Oct 4, 2024

documented statisticsId field

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@hxrshxz
Copy link
Author

hxrshxz commented Oct 5, 2024

I have signed the CLA. kindly review my PR now

damencho
damencho previously approved these changes Oct 5, 2024
@@ -367,11 +367,17 @@ JitsiConference.resourceCreator = function(jid, isAuthenticatedUser) {
* @param options {object}
* @param options.connection {JitsiConnection} overrides this.connection
*/

/**
* Class JitsiConferenceOptions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be blended with the above comment since it describes the class already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes you suggested

JitsiConference.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants