Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isScannerAvailable #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

altimas
Copy link

@altimas altimas commented Mar 5, 2022

Trying my hand at adding a feature to this Repo.

Tried Symlinking it to my Ionic Repo I want to use it in, but it doesn't seem to be working for some reason when I run the Ionic android build and run it on the device to test it.

But wanted throw this up and get some feedback on how I implemented it and if @jkbz64 has any suggestions on edits/fixes or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.

@jkbz64
Copy link
Owner

jkbz64 commented Mar 5, 2022

Aside from the formatting inconsistencies looks mostly correct, good job 👍
There are some things that caught my eye so I will request changes for them right now, to merge the changes completely I will need to test it on the real device somewhere in the coming week (don't have device on hand), might post rest of the requested changes then if any appear.

@altimas
Copy link
Author

altimas commented Mar 5, 2022

Thanks! I appreciate it, its been about 20 years since I really sat down and wrote Java. So any feedback is more than welcome.

@jkbz64
Copy link
Owner

jkbz64 commented Mar 5, 2022

or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.

Pretty sure going into the plugin repository and calling npm link then going to your project repository and calling npm link capacitor-datawedge symlinks the repos properly then all you need is to call npx cap sync to sync the plugin files but that is with plain capacitor, haven't used Ionic personally, don't know if that makes a difference.

@altimas
Copy link
Author

altimas commented Mar 5, 2022

or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.

Pretty sure going into the plugin repository and calling npm link then going to your project repository and calling npm link capacitor-datawedge symlinks the repos properly then all you need is to call npx cap sync to sync the plugin files but that is with plain capacitor, haven't used Ionic personally, don't know if that makes a difference.

Ahhhh I forgot the 'npx cap sync' part. Will try that when I get back home. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants