worksheet: fix repeat_row() issue with quoted sheet names

Add a fix for an issue where a worksheet name needed quoting when
used with a repeat_row()/Print_Titles defined name.

Issue #1078

xlsxwriter/test/comparison/test_quote_name05.py

@@ -25,7 +25,9 @@ def test_create_file(self):
 
         workbook = Workbook(self.got_filename)
 
-        worksheet = workbook.add_worksheet()
+        sheet_name = "Sheet1"
+
+        worksheet = workbook.add_worksheet(sheet_name)
         chart = workbook.add_chart({"type": "column"})
 
         chart.axis_ids = [54437760, 59195776]
@@ -44,9 +46,9 @@ def test_create_file(self):
         worksheet.set_portrait()
         worksheet.vertical_dpi = 200
 
-        chart.add_series({"values": ["Sheet1", 0, 0, 4, 0]})
-        chart.add_series({"values": ["Sheet1", 0, 1, 4, 1]})
-        chart.add_series({"values": ["Sheet1", 0, 2, 4, 2]})
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
 
         worksheet.insert_chart("E9", chart)
 

xlsxwriter/test/comparison/test_quote_name06.py

@@ -25,7 +25,9 @@ def test_create_file(self):
 
         workbook = Workbook(self.got_filename)
 
-        worksheet = workbook.add_worksheet("Sheet-1")
+        sheet_name = "Sheet-1"
+
+        worksheet = workbook.add_worksheet(sheet_name)
         chart = workbook.add_chart({"type": "column"})
 
         chart.axis_ids = [62284544, 83429248]
@@ -44,9 +46,9 @@ def test_create_file(self):
         worksheet.set_portrait()
         worksheet.vertical_dpi = 200
 
-        chart.add_series({"values": ["Sheet-1", 0, 0, 4, 0]})
-        chart.add_series({"values": ["Sheet-1", 0, 1, 4, 1]})
-        chart.add_series({"values": ["Sheet-1", 0, 2, 4, 2]})
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
 
         worksheet.insert_chart("E9", chart)
 

xlsxwriter/test/comparison/test_quote_name07.py

@@ -25,7 +25,9 @@ def test_create_file(self):
 
         workbook = Workbook(self.got_filename)
 
-        worksheet = workbook.add_worksheet("Sheet'1")
+        sheet_name = "Sheet'1"
+
+        worksheet = workbook.add_worksheet(sheet_name)
         chart = workbook.add_chart({"type": "column"})
 
         chart.axis_ids = [48135552, 54701056]
@@ -44,9 +46,10 @@ def test_create_file(self):
         worksheet.set_portrait()
         worksheet.vertical_dpi = 200
 
-        chart.add_series({"values": ["Sheet'1", 0, 0, 4, 0]})
-        chart.add_series({"values": ["Sheet'1", 0, 1, 4, 1]})
-        chart.add_series({"values": ["Sheet'1", 0, 2, 4, 2]})
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
+
         worksheet.insert_chart("E9", chart)
 
         workbook.close()

xlsxwriter/test/comparison/test_quote_name08.py

@@ -0,0 +1,57 @@
+###############################################################################
+#
+# Tests for XlsxWriter.
+#
+# SPDX-License-Identifier: BSD-2-Clause
+# Copyright (c), 2013-2023, John McNamara, jmcnamara@cpan.org
+#
+
+from ..excel_comparison_test import ExcelComparisonTest
+from ...workbook import Workbook
+
+
+class TestCompareXLSXFiles(ExcelComparisonTest):
+    """
+    Test file created by XlsxWriter against a file created by Excel.
+
+    """
+
+    def setUp(self):
+
+        self.set_filename("quote_name08.xlsx")
+
+    def test_create_file(self):
+        """Test the creation of a simple XlsxWriter file."""
+
+        workbook = Workbook(self.got_filename)
+
+        sheet_name = "1Sheet"
+
+        worksheet = workbook.add_worksheet(sheet_name)
+        chart = workbook.add_chart({"type": "column"})
+
+        chart.axis_ids = [55487104, 84573184]
+
+        data = [
+            [1, 2, 3, 4, 5],
+            [2, 4, 6, 8, 10],
+            [3, 6, 9, 12, 15],
+        ]
+
+        worksheet.write_column("A1", data[0])
+        worksheet.write_column("B1", data[1])
+        worksheet.write_column("C1", data[2])
+
+        worksheet.repeat_rows(0, 1)
+        worksheet.set_portrait()
+        worksheet.vertical_dpi = 200
+
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
+
+        worksheet.insert_chart("E9", chart)
+
+        workbook.close()
+
+        self.assertExcelEqual()

xlsxwriter/test/comparison/test_quote_name09.py

@@ -0,0 +1,57 @@
+###############################################################################
+#
+# Tests for XlsxWriter.
+#
+# SPDX-License-Identifier: BSD-2-Clause
+# Copyright (c), 2013-2023, John McNamara, jmcnamara@cpan.org
+#
+
+from ..excel_comparison_test import ExcelComparisonTest
+from ...workbook import Workbook
+
+
+class TestCompareXLSXFiles(ExcelComparisonTest):
+    """
+    Test file created by XlsxWriter against a file created by Excel.
+
+    """
+
+    def setUp(self):
+
+        self.set_filename("quote_name09.xlsx")
+
+    def test_create_file(self):
+        """Test the creation of a simple XlsxWriter file."""
+
+        workbook = Workbook(self.got_filename)
+
+        sheet_name = "Sheet_1"
+
+        worksheet = workbook.add_worksheet(sheet_name)
+        chart = workbook.add_chart({"type": "column"})
+
+        chart.axis_ids = [54437760, 59195776]
+
+        data = [
+            [1, 2, 3, 4, 5],
+            [2, 4, 6, 8, 10],
+            [3, 6, 9, 12, 15],
+        ]
+
+        worksheet.write_column("A1", data[0])
+        worksheet.write_column("B1", data[1])
+        worksheet.write_column("C1", data[2])
+
+        worksheet.repeat_rows(0, 1)
+        worksheet.set_portrait()
+        worksheet.vertical_dpi = 200
+
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
+
+        worksheet.insert_chart("E9", chart)
+
+        workbook.close()
+
+        self.assertExcelEqual()

xlsxwriter/test/comparison/test_quote_name10.py

@@ -0,0 +1,57 @@
+###############################################################################
+#
+# Tests for XlsxWriter.
+#
+# SPDX-License-Identifier: BSD-2-Clause
+# Copyright (c), 2013-2023, John McNamara, jmcnamara@cpan.org
+#
+
+from ..excel_comparison_test import ExcelComparisonTest
+from ...workbook import Workbook
+
+
+class TestCompareXLSXFiles(ExcelComparisonTest):
+    """
+    Test file created by XlsxWriter against a file created by Excel.
+
+    """
+
+    def setUp(self):
+
+        self.set_filename("quote_name10.xlsx")
+
+    def test_create_file(self):
+        """Test the creation of a simple XlsxWriter file."""
+
+        workbook = Workbook(self.got_filename)
+
+        sheet_name = "Sh.eet.1"
+
+        worksheet = workbook.add_worksheet(sheet_name)
+        chart = workbook.add_chart({"type": "column"})
+
+        chart.axis_ids = [46905600, 46796800]
+
+        data = [
+            [1, 2, 3, 4, 5],
+            [2, 4, 6, 8, 10],
+            [3, 6, 9, 12, 15],
+        ]
+
+        worksheet.write_column("A1", data[0])
+        worksheet.write_column("B1", data[1])
+        worksheet.write_column("C1", data[2])
+
+        worksheet.repeat_rows(0, 1)
+        worksheet.set_portrait()
+        worksheet.vertical_dpi = 200
+
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
+
+        worksheet.insert_chart("E9", chart)
+
+        workbook.close()
+
+        self.assertExcelEqual()

xlsxwriter/test/comparison/test_quote_name11.py

@@ -0,0 +1,57 @@
+###############################################################################
+#
+# Tests for XlsxWriter.
+#
+# SPDX-License-Identifier: BSD-2-Clause
+# Copyright (c), 2013-2023, John McNamara, jmcnamara@cpan.org
+#
+
+from ..excel_comparison_test import ExcelComparisonTest
+from ...workbook import Workbook
+
+
+class TestCompareXLSXFiles(ExcelComparisonTest):
+    """
+    Test file created by XlsxWriter against a file created by Excel.
+
+    """
+
+    def setUp(self):
+
+        self.set_filename("quote_name11.xlsx")
+
+    def test_create_file(self):
+        """Test the creation of a simple XlsxWriter file."""
+
+        workbook = Workbook(self.got_filename)
+
+        sheet_name = "Sheeté"
+
+        worksheet = workbook.add_worksheet(sheet_name)
+        chart = workbook.add_chart({"type": "column"})
+
+        chart.axis_ids = [46720128, 46721664]
+
+        data = [
+            [1, 2, 3, 4, 5],
+            [2, 4, 6, 8, 10],
+            [3, 6, 9, 12, 15],
+        ]
+
+        worksheet.write_column("A1", data[0])
+        worksheet.write_column("B1", data[1])
+        worksheet.write_column("C1", data[2])
+
+        worksheet.repeat_rows(0, 1)
+        worksheet.set_portrait()
+        worksheet.vertical_dpi = 200
+
+        chart.add_series({"values": [sheet_name, 0, 0, 4, 0]})
+        chart.add_series({"values": [sheet_name, 0, 1, 4, 1]})
+        chart.add_series({"values": [sheet_name, 0, 2, 4, 2]})
+
+        worksheet.insert_chart("E9", chart)
+
+        workbook.close()
+
+        self.assertExcelEqual()