drivers: gpio fixed according to hal issue #60

jnaulet · Jul 16, 2023 · afd146b · afd146b
1 parent 41525a9
commit afd146b
Show file tree

Hide file tree

Showing 8 changed files with 118 additions and 10 deletions.
diff --git a/drivers/gpio/gpio-avr.c b/drivers/gpio/gpio-avr.c
@@ -31,11 +31,23 @@ int gpio_avr_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
-/* HAL */
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
 
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-gd32vf103.c b/drivers/gpio/gpio-gd32vf103.c
@@ -34,9 +34,23 @@ int gpio_gd32vf103_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-pic32mx.c b/drivers/gpio/gpio-pic32mx.c
@@ -32,9 +32,23 @@ int gpio_pic32mx_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-rp2040_sio.c b/drivers/gpio/gpio-rp2040_sio.c
@@ -53,9 +53,23 @@ int gpio_rp2040_sio_init(struct gpio *ctx, int base,
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-sam3x_pio.c b/drivers/gpio/gpio-sam3x_pio.c
@@ -80,9 +80,23 @@ int gpio_sam3x_pio_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-same5x.c b/drivers/gpio/gpio-same5x.c
@@ -38,9 +38,23 @@ int gpio_same5x_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-ti_f28x.c b/drivers/gpio/gpio-ti_f28x.c
@@ -31,11 +31,23 @@ int gpio_ti_f28x_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
-/* hooks */
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
 
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }
 

diff --git a/drivers/gpio/gpio-tinyavr.c b/drivers/gpio/gpio-tinyavr.c
@@ -41,9 +41,23 @@ int gpio_tinyavr_init(struct gpio *ctx, int base, size_t pin)
     return 0;
 }
 
+static int set_invert(struct gpio *ctx, gpio_invert_t invert)
+{
+    if (!picoRTOS_assert(invert != GPIO_INVERT_IGNORE)) return -EINVAL;
+    if (!picoRTOS_assert(invert < GPIO_INVERT_COUNT)) return -EINVAL;
+
+    ctx->invert = (invert == GPIO_INVERT_ENABLE);
+    return 0;
+}
+
 int gpio_setup(struct gpio *ctx, struct gpio_settings *settings)
 {
-    ctx->invert = settings->invert;
+    int res;
+
+    if (settings->invert != GPIO_INVERT_IGNORE &&
+        (res = set_invert(ctx, settings->invert)) < 0)
+        return res;
+
     return 0;
 }