Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable scrolling with Trackpad #274

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

hayashikun
Copy link
Contributor

I can scroll with the mouse wheel, but I cannot with the trackpad.

This is because scroll events from the trackpad are sent via onPointerPanZoomUpdate, not onPointerSignal.
https://docs.flutter.dev/release/breaking-changes/trackpad-gestures

By sending the amount of scroll, panDelta in PointerPanZoomUpdateEvent, to the webview, I can scroll with the trackpad.

Related issues: #258

@NotTsunami
Copy link

This is a fantastic find. Hopefully it can get merged soon. Cheers!

Copy link
Owner

@jnschulze jnschulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you.

@jnschulze jnschulze merged commit bf6bb71 into jnschulze:main Feb 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants