Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BasedPyright LSP #1375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

baco
Copy link

@baco baco commented Mar 19, 2024

There is a new LSP server for Python, fork of unmaintained pyright LSP server.

The goal of this new LSP server is to also include features delegated to the closed source pylance LSP server.

Added BasedPyright, a new server for python, forked from the unmaintained
`pyright` LSP server
Added the BasedPyright information for new Python's LSP
@joaotavora
Copy link
Owner

This is great, great name for the new server and great idea, and I fully support the idea. pyright is somewhat poorly maintained in my opinion, and we needed this. But you know what would even be better? A PR to the README.md making it even more clear that development of Eglot does NOT take place in this repository, but rather in the Emacs upstream via bug-gnu-emacs@gnu.org. Send your patch there, please, and the Emacs maintainers will very likely install it.

@baco
Copy link
Author

baco commented Mar 23, 2024

I've done it. I didn't receive any response yet.

@joaotavora
Copy link
Owner

I've done it. I didn't receive any response yet.

OK, it will eventually get some attention, I believe. In the meantime it's not like it's super hard to type M-x eglot RET basedpyright-langserver -lsp or somesuch right? Or (add-to-list eglot-server-programs as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants