Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add default values to list of variables + some QA #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ewjmulder
Copy link

When using default values, the script printed a warning for each default value: "... is not defined and no default is set, replacing by empty". Also when using the -p flag, you can see each default value as a variable with no value.

The cause is a line where each default value is added to the list of variables. This makes no sense to me, so I guess it's a bug. In this PR I removed that and indeed that gets rid of the warning. If there is any reason for that line that I missed, please inform me.

I also included some other small QA changes that I think make sense: fixed a typo, removed trailing whitespace and usage of $() instead of backticks.

Thanks for the great script! Perfect to use in a lean Docker container for some simple templating. Looking forward to your response.

@johanhaleby
Copy link
Owner

Thanks for the PR. I need to look into this some more before I can answer your question. Stay tuned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants