Don't add default values to list of variables + some QA #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using default values, the script printed a warning for each default value: "... is not defined and no default is set, replacing by empty". Also when using the -p flag, you can see each default value as a variable with no value.
The cause is a line where each default value is added to the list of variables. This makes no sense to me, so I guess it's a bug. In this PR I removed that and indeed that gets rid of the warning. If there is any reason for that line that I missed, please inform me.
I also included some other small QA changes that I think make sense: fixed a typo, removed trailing whitespace and usage of $() instead of backticks.
Thanks for the great script! Perfect to use in a lean Docker container for some simple templating. Looking forward to your response.