evaluate static string matches in TypedExprNormalization #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
Nov 19, 2024
| ] | ||
| ): Option[Expr] = | ||
| arg match { | ||
| case Literal(Lit.Str(s)) => |
There was a problem hiding this comment.
We could extend this very easily to any Literal which is probably all we need to handle here.
That said, maybe this code should really be pushed into TypedExprNormalization since applying these optimizations could open other normalizations.
johnynek
commented
Nov 19, 2024
| import org.scalacheck.Prop.forAll | ||
| import org.scalacheck.Gen | ||
|
|
||
| class StrPartTest extends munit.ScalaCheckSuite { |
There was a problem hiding this comment.
this test actually also tests that all the matching algorithms agree. It seems we have something like 4 of them:
- StrPart
- SeqPattern + matcher
- NamedSeqPattern + matcher
- java regex
There was a problem hiding this comment.
I think StrPart is the fastest, but I haven't carefully benchmarked it, but they should all agree, and the speed only matters for the MatchlessToValue runtime, in normalization, it doesn't matter I don't think.
johnynek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we are generating code for static string matches that could be done in advance.
This refactors to use the existing string matching code statically.