Refacto EmployeeController based on PrestaShopAdminController

jolelievre · Oct 17, 2024 · 6e68643 · 6e68643
1 parent 999336f
commit 6e68643
Show file tree

Hide file tree

Showing 11 changed files with 125 additions and 185 deletions.
diff --git a/src/Adapter/Employee/EmployeeFormAccessChecker.php b/src/Adapter/Employee/EmployeeFormAccessChecker.php
@@ -61,7 +61,7 @@ public function __construct(
     /**
      * {@inheritdoc}
      */
-    public function isRestrictedAccess($employeeId)
+    public function isRestrictedAccess(int $employeeId): bool
     {
         if (!is_int($employeeId)) {
             throw new InvalidArgumentException(sprintf('Employee ID must be an integer, %s given', gettype($employeeId)));
@@ -73,7 +73,7 @@ public function isRestrictedAccess($employeeId)
     /**
      * {@inheritdoc}
      */
-    public function canAccessEditFormFor($employeeId)
+    public function canAccessEditFormFor(int $employeeId): bool
     {
         // To access super admin edit form you must be a super admin.
         if ($this->employeeDataProvider->isSuperAdmin($employeeId)) {

diff --git a/src/Adapter/Employee/FormLanguageChanger.php b/src/Adapter/Employee/FormLanguageChanger.php
@@ -54,7 +54,7 @@ public function __construct(LegacyContext $legacyContext)
     /**
      * {@inheritdoc}
      */
-    public function changeLanguageInCookies($languageIsoCode)
+    public function changeLanguageInCookies(string $languageIsoCode): void
     {
         $this->legacyContext->getContext()->cookie->employee_form_lang = (int) Language::getIdByIso($languageIsoCode);
         $this->legacyContext->getContext()->cookie->write();

diff --git a/src/Adapter/Employee/NavigationMenuToggler.php b/src/Adapter/Employee/NavigationMenuToggler.php
@@ -50,7 +50,7 @@ public function __construct(LegacyContext $legacyContext)
     /**
      * {@inheritdoc}
      */
-    public function toggleNavigationMenuInCookies($shouldCollapse)
+    public function toggleNavigationMenuInCookies(bool $shouldCollapse): void
     {
         $this->legacyContext->getContext()->cookie->collapse_menu = (int) $shouldCollapse;
         $this->legacyContext->getContext()->cookie->write();

diff --git a/src/Core/Employee/Access/EmployeeFormAccessCheckerInterface.php b/src/Core/Employee/Access/EmployeeFormAccessCheckerInterface.php
@@ -42,7 +42,7 @@ interface EmployeeFormAccessCheckerInterface
      *
      * @return bool
      */
-    public function isRestrictedAccess($employeeId);
+    public function isRestrictedAccess(int $employeeId): bool;
 
     /**
      * Check if context employee can access edit form for given employee.
@@ -51,5 +51,5 @@ public function isRestrictedAccess($employeeId);
      *
      * @return bool
      */
-    public function canAccessEditFormFor($employeeId);
+    public function canAccessEditFormFor(int $employeeId): bool;
 }
diff --git a/src/Core/Employee/FormLanguageChangerInterface.php b/src/Core/Employee/FormLanguageChangerInterface.php
@@ -36,5 +36,5 @@ interface FormLanguageChangerInterface
      *
      * @param string $languageIsoCode two letter iso code of the language
      */
-    public function changeLanguageInCookies($languageIsoCode);
+    public function changeLanguageInCookies(string $languageIsoCode): void;
 }
diff --git a/src/Core/Employee/NavigationMenuTogglerInterface.php b/src/Core/Employee/NavigationMenuTogglerInterface.php
@@ -36,5 +36,5 @@ interface NavigationMenuTogglerInterface
      *
      * @param bool $shouldCollapse if true - collapse the navigation, expand it otherwise
      */
-    public function toggleNavigationMenuInCookies($shouldCollapse);
+    public function toggleNavigationMenuInCookies(bool $shouldCollapse): void;
 }
diff --git a/src/Core/Team/Employee/Configuration/OptionsChecker.php b/src/Core/Team/Employee/Configuration/OptionsChecker.php
@@ -59,7 +59,7 @@ public function __construct(
     /**
      * {@inheritdoc}
      */
-    public function canBeChanged()
+    public function canBeChanged(): bool
     {
         if (!$this->multistoreFeature->isUsed()
             && $this->multistoreContextChecker->isSingleShopContext()

diff --git a/src/Core/Team/Employee/Configuration/OptionsCheckerInterface.php b/src/Core/Team/Employee/Configuration/OptionsCheckerInterface.php
@@ -36,5 +36,5 @@ interface OptionsCheckerInterface
      *
      * @return bool
      */
-    public function canBeChanged();
+    public function canBeChanged(): bool;
 }