Update branch to main #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing redundant imports --------- Co-authored-by: Greg Baimetov <githubemail@example.com>
Co-authored-by: Greg Baimetov <githubemail@example.com> Co-authored-by: Joseph Sumabat <josephrsumabat@gmail.com>
There are a few edge cases with the caching scheme we use that can result in incorrect or missing language intelligence in certain cases. Events which change a file _without_ triggering a change or save handler in the lsp can result in a stale cache and consequently the aforementioned issues. This resolves most cases - We check file metadata to invalidate the hie cache if a newer hie file is detected - If a file is saved then we invalidate the file state cache (this doesn't solve all stale file state cache issues but works for cases which use a file watcher such as ghciwatch for a recompile).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.