Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct javax.activation scope #258

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Correct javax.activation scope #258

merged 1 commit into from
Jun 17, 2024

Conversation

chadlwilson
Copy link
Contributor

This only seems to be used within tests at

public static String getMimeType(String filePath) {
return FileTypeMap.getDefaultFileTypeMap().getContentType(filePath);
}
so note needed as a new runtime dependency (especially as it's a very old API version)?

This only seems to be used within tests at https://github.com/jruby/jruby-rack/blob/a965a33a23a484371e81a01048714106acda6230/src/spec/java/org/jruby/rack/mock/MockServletContext.java#L466-L468 so note needed as a new runtime dependency (especially as it's a very old API version)?
@headius
Copy link
Member

headius commented Jun 17, 2024

Seems appropriate to me!

@headius headius added this to the 1.2.3 milestone Jun 17, 2024
@headius headius merged commit 805c3d2 into jruby:master Jun 17, 2024
1 check passed
@chadlwilson chadlwilson deleted the patch-2 branch June 18, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants