Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements on dialogflow and google chat #451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Apr 10, 2023

  • google_chat_ros/script/helper.py: add ~send_dialogflow_resonse_to_google_chat param. Set False did not returns dialogflow response to chat
    
  • dialogflow_task_executive: add more info, set_preempted when ActionServer fails, set df_result == None as initial value
    

…rver fails, set df_result == None as initial value
google_chat_ros/launch/google_chat.launch Outdated Show resolved Hide resolved
@@ -18,6 +18,7 @@ def __init__(self):
# Get configuration params
self.to_dialogflow_task_executive = rospy.get_param("~to_dialogflow_client")
self.sound_play_jp = rospy.get_param("~debug_sound")
self.send_dialogflow_resonse_to_google_chat = rospy.get_param("~send_dialogflow_resonse_to_google_chat", True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.send_dialogflow_resonse_to_google_chat = rospy.get_param("~send_dialogflow_resonse_to_google_chat", True)
self.send_dialogflow_response_to_google_chat = rospy.get_param("~send_dialogflow_response_to_google_chat", True)

google_chat_ros/launch/google_chat.launch Outdated Show resolved Hide resolved
google_chat_ros/scripts/helper.py Outdated Show resolved Hide resolved
@k-okada k-okada changed the title improvements on dialogfwo and google chat improvements on dialogflow and google chat Apr 13, 2023
…ogle_chat param. Set False did not returns dialogflow response to chat
@k-okada
Copy link
Member Author

k-okada commented Apr 18, 2023

we may do not need send_dialogflow_resonse_to_google_chat
k-okada/jsk_robot@2c69055#r109428201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants