Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_chat_ros: enable to get therad_name message result #498

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Oct 29, 2023

another imprementation of #496

@mqcmd196 I have created PR, how about enabling :ac option. Beacuase current implementation initialize publisher/subscriber everytime we call function. This is good for example code, but hard to use in demo code.

(send-google-chat-text "spaces/AAAARE9CrfA" "Hello" :ac (instance ros::simple-action-client :init action-goal-name google_chat_ros::SendMessageAction)))

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I have created PR, how about enabling :ac option. Beacuase current implementation initialize publisher/subscriber everytime we call function. This is good for example code, but hard to use in demo code.

Yes, I think it is hard to use in demo, so I agree with this point.

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so merge #496 ?

@k-okada
Copy link
Member Author

k-okada commented Nov 1, 2023

#496 (comment) says

@k-okada
I think

Another solution would be to return the result of the message like https://github.com/k-okada/jsk_3rdparty/commit/e9a4904cb2449ab86415d8d4046592546a42b801 and write code like this

is better because the eus function is designed to be usable without knowing the detailed message specifications.

so pass SimpleActionClient and return result?

@mqcmd196
Copy link
Member

mqcmd196 commented Nov 2, 2023

I mean enabling the option

how about enabling :ac option. Beacuase current implementation initialize publisher/subscriber everytime we call function

and if the :ac is set, the function uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants