Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont require corrections for licensee #98

Closed
wants to merge 1 commit into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 6, 2024

User story: I would like to add licensee as a dev-dep, and run licensee without --corrections, and without having to manually add a license exception.

@kemitchell
Copy link
Member

Could you further explain your rationale for this change?

If it's that docopt doesn't have license metadata set, you can also get 0 exit codes by adding a package-specific exception to your Licensee configuration file.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 6, 2024

This tool should choose dependencies that are properly licensed, so that it isnt the cause of improperly licensed dependencies being added to users dependency tree.

@kemitchell
Copy link
Member

Could you please be more specific?

If your concern is the docopt npm package, please have a look at the LICENSE-MIT file in its repository.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 6, 2024

The concern is that docopt's published version lacks the licensing metadata needed by lots of software composition analysis (SCA) tools.

As licensee.js is a SCA tool, I expect it to have dependencies that are free of SCA problems.

As you have been a committer to docopt project, perhaps you can also help with resolving the problem there, which would be even better than solving it here.
c.f. stuartcarnie/docopt.coffee#14 (comment)

@kemitchell
Copy link
Member

As licensee.js is a SCA tool, I expect it to have dependencies that are free of SCA problems.

Neither I nor any other committer here owes you any time or attention. When asking for our help, I'd suggest you'll have more success asking politely and taking the time to thoroughly explain the changes you propose. Not making work here while you also address the direct issue with docopt. Not by writing "I expect" when what you really mean is just "I want".

@kemitchell kemitchell closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants