Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report busy job metrics for correct queues #77

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

karls
Copy link
Collaborator

@karls karls commented Nov 30, 2023

This PR fixes two issues with TRACK_BUSY_JOBS=True:

  • Even if the developer had specified the QUEUES=[...] option in their Judoscale configuration, the adapter was reporting busy jobs metrics for other queues as well as the specified queues.
  • If no tasks were being processed, no busy jobs metrics were being reported either.

Copy link
Contributor

@adamlogic adamlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@karls karls merged commit f13be08 into main Dec 1, 2023
4 checks passed
@karls karls deleted the fix-busy-jobs-reporting branch December 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants