Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: logic of render tex in processMath #18

Merged
merged 1 commit into from
May 9, 2024

Conversation

Kim716
Copy link

@Kim716 Kim716 commented May 9, 2024

Pull Request Title 請加上 prefix,e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link:
https://www.notion.so/junyiacademy/number-line-widget-51c64316abb7437294cf1935280c8d55?pvs=4

Introduction

請說明此 Pull Request 的目的

  • 因為均一主站無法利用這邊的 code 順利渲染出 TeX,反而會跳出 error => nvalid hook call,所以刪除這邊的 code,改到均一 repo 去 render

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的(或是做過哪些驗證)

  • 目前盤點只有使用到 graphie.label 第四個參數為 truthy 時會觸發到這段 code,目前新版已搬遷的 widgets 都不會「觸發」到,所以不會影響到已搬遷 widgets

@Kim716 Kim716 self-assigned this May 9, 2024
Copy link

@esp10mm esp10mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

會需要改 package.json 版本號嗎

this logic can not run correctly in junyi
@Kim716 Kim716 force-pushed the remove/process-math-render-tex branch from 41b5cc8 to b283585 Compare May 9, 2024 08:45
@Kim716 Kim716 merged commit 4c92db7 into main May 9, 2024
@Kim716 Kim716 added the 🔧 publish-npm Add this tag will publish perseus-core to npm label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants