Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable static targets #52

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Enable static targets #52

merged 2 commits into from
Sep 9, 2024

Conversation

IsabelParedes
Copy link
Member

@IsabelParedes IsabelParedes commented Jun 17, 2024 •
edited
Loading

When building static libraries only (e.g. emscripten-forge), find_package(xvega REQUIRED) fails because there are no static targets installed.

CMake Error at $PREFIX/lib/cmake/xvega/xvegaConfig.cmake:45 (include):
  include could not find requested file:
    $PREFIX/lib/cmake/xvega/xvegaTargets.cmake

@IsabelParedes IsabelParedes marked this pull request as ready for review June 17, 2024 12:05
JohanMabille
JohanMabille approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can take the opportunity to remove this condition (i.e. always install)

@IsabelParedes IsabelParedes mentioned this pull request Jun 17, 2024
Draft
@IsabelParedes IsabelParedes merged commit ad372ff into jupyter-xeus:main Sep 9, 2024
3 checks passed
@IsabelParedes IsabelParedes deleted the static branch September 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsabelParedes @JohanMabille