Skip to content

Commit

Permalink
Add accessibility meeting notes for end of 2022 and beginning of 2023 (
Browse files Browse the repository at this point in the history
…#137)

* Fix 2022 meeting notes index
* Add end of 2022 notes
* Add 2023 meeting notes
* Create 2023 notes index
* Add 2023 notes to main meeting notes directory
* Add end of 2022 and beginning of 2023 notes to all minutes
* Update docs/community/meeting-minutes/jupyterlab-accessibility-meetings/2022/index.md
* Update docs/community/meeting-minutes/jupyterlab-accessibility-meetings/all-minutes.md
Co-authored-by: gabalafou <gabriel@fouasnon.com>

---------

Co-authored-by: Tony Fast <tony.fast@gmail.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
  • Loading branch information
3 people authored Sep 12, 2023
1 parent d5b310d commit 7b8d0bb
Show file tree
Hide file tree
Showing 28 changed files with 1,911 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
## 9.21.22

### Attendees

- Darian
- Tania
- Gabriel
- Ryan
- Ely

### Agenda

- Discussing depth-levels in JupyterLab/lumino codebases
- Example that sparked this conversation https://github.com/jupyterlab/jupyterlab/pull/13109
- Most recent Zoom audit in JupyterLab and findings https://github.com/Quansight-Labs/jupyterlab-accessible-themes/issues/34
- Examples of manual-testing scripts we are working on https://github.com/Quansight-Labs/jupyter-a11y-testing/tree/main/testing/scripts
- Darian: is happy to offer office hours to help folks orient around the codebase
- Ely: had plenty support from Jason when walking this path
- Ely: some helpful information was around panel, CSS, historical context (from Jason), panels needed for a particular situation
- Provide examples of extensions with the panels/layout explanations (maybe in the readme in Lumino)
- Tania: could we look at codetours for example? https://github.com/microsoft/codetour
- Adjacent: Tania proposed this docs reorg (JupyterLab) https://github.com/jupyterlab/jupyterlab/issues/7387
- Darian: proposal -> use some of these calls to do "BBQ bonanza/triage" -> find where the issue resides to help fixing this
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
## October 5 2022

### Attendees

- Jeremy (might not be able to attend)
- Frederic
- Mike
- Gabriel
- Isabela
- Allison
- Darian
- Frederic
- Martha
- Detroit
- Balaji
- Ryan

### Agenda

- Mike:
- Shadow DOM
- Jeremy:
- A new pre-release of Notebook 7 is available: https://github.com/jupyter/notebook/releases/tag/v7.0.0a6
- Discourse topic: https://discourse.jupyter.org/t/notebook-7-pre-releases-are-available/16063
- It includes the switch to **CodeMirror 6** that landed in JupyterLab: https://github.com/jupyterlab/jupyterlab/pull/11638
- Closed the old issue on the RetroLab repo that was about doing an accessibility audit on the RetroLab UI: https://github.com/jupyterlab/retrolab/issues/80. Now that the CodeMirror 6 update is available in a Notebook 7 pre-release it should be possible to make this audit with a document-oriented notebook UI.
- There is no development happening in `jupyterlab/retrolab` anymore, improvements and fixes should be done in JupyterLab and Notebook 7.
- Happy to help in the `jupyter/notebook` or `jupyter/accessibility`. Please report any issue if you find any, thanks!
- Try it on Binder with this gist: https://gist.github.com/jtpio/d368ab89cee5123ecee60683115e15f3

- Frederic
- [Improvements of tab panel labelledby](https://github.com/jupyterlab/lumino/pull/407) - will be part of 3.5.0
- Some related work with consistency of CSS variables between background color and text color:
- [Link background colors and ui font colors in the style](https://github.com/jupyterlab/jupyterlab/pull/13173)
This was seen when working on a [JupyterLab theme editor](https://github.com/HaudinFlorence/jupyterlab-theme-editor)

- Mike v2:
- low hanging fruit good first issue for new contributors https://github.com/jupyterlab/jupyterlab/issues/13045

- Isabela
- Office hours follow up (from last meeting)?
- Council updates?
- [Browser zoom support](https://www.w3.org/WAI/WCAG21/Understanding/reflow.html)[(early) ideas for JupyterLab?](https://github.com/Quansight-Labs/jupyterlab-accessible-themes/issues/34#issuecomment-1228911639)

- Gabriel
- If we have time for office hours, can we chat about tab focus indicators and/or tab traps in code cells?

### Next steps
- Shadow DOM needs more research and/or a binder to test it in
- Explore [Notebook 7](https://gist.github.com/jtpio/d368ab89cee5123ecee60683115e15f3). [Report Notebook 7 issues](https://github.com/jupyter/notebook/issues).
- Add "office hours" help for under agenda and make a queue of issues to pull from
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## October 19 2022

### Attendees

- Mike
- Isabela
- Gabriel
- Stephannie
- Martha
- Gérard
- Tania
- Ryan
- Balaji
- Kseniya
- Israel

### Agenda

- Isabela
- Discussion on directions for high browser zoom and JupyterLab at [jupyterlab/jupyterlab #10004](https://github.com/jupyterlab/jupyterlab/issues/10004#issuecomment-1276957564). Please weigh in!
- Mike: Another approach would be to have UI and document zoom approached separately since it is possible they are different use cases.
- Mike: "A datapoint for previous discussion: in VScode the default is to zoom everything and user needs to enable document zooming manually though they divide ctrl + scroll as it seems."
- For anyone curious, here is what we did [on the collaborative keyboard navigation review for the Notebook 7 prerelease](https://github.com/isabela-pf/a11y-events/pull/10). It will become an issue elsewhere.

- Gabriel
- Sneak peek on some of the work I'm doing. tl;dr-- Run accessibility regression tests via GitHub Actions against a JupyterLab PR, showing if it breaks (or fixes) any regression tests.

- Copy this to next meeting's agenda: For the remainining meeting time, can we open up and dig into CodeMirror? -Gabriel
[name=Tania] I am interested in this, mostly how can we "test" for the newly introduced accessibility features
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
## November 2 2022

### Attendees

- Darian
- Gabriel
- Stephannie
- Isabela
- Martha
- Ely
- Ryan
- Mike
- Kseniya
- Balaji
- Tania

### Agenda
- Isabela
- Update on Space Telescope user testing results. This [resources PR](https://github.com/Iota-School/notebooks-for-all/pull/26) provides all info used to plan the tests so far and script, notebook used, and takeaways from the first round of tests.
- Mike
- nbdime? Keep an eye out for any PRs here because this could relate to the inaccessibility of the space. We should review any PRs with this in mind.
- Darian
- Rick mentioned someone from UC Berkeley might contact us re: accessibility for Jupyter tools deployed there
- Jupyter Executive Council election
- For the remainining meeting time, can we open up and dig into CodeMirror? -Gabriel
[name=Tania] I am interested in this, mostly how can we "test" for the newly introduced accessibility features
- https://github.com/berkeley-dsep-infra/datahub/issues/3885
https://playwright.dev/docs/accessibility-testing
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
## November 16 2022

### Attendees

- Darian
- Gabriel
- Stephannie
- Isabela
- Tania
- Mark
- Detroit
- Ryan
- tf
- Sylvain
- Ely

### Agenda

- Special guest appearance: Katie
[name=Tania]- Since Darian mentioned an audit (potential) it would be definitely good to keep in sync and find a way to standardise our auditing processes in Jupyter-world

- Isabela
- Update on Space Telescope [user testing results](https://github.com/Iota-School/notebooks-for-all/blob/main/user-tests/1-navigation/results.md). We have more complete takeaways from the first round of tests. If there's any interest in me sharing the results or answering questions, let me know!
- For desired reflow in JupyterLab, please feel free to weigh in on [jupyterlab/jupyterlab #10004](https://github.com/jupyterlab/jupyterlab/issues/10004#issuecomment-1276957564). I'm trying to keep this moving forward and would like if we can get to a decided direction.
- Regarding reflow Darian/Sylvain does any of you have ideas/suggestions on moving this forward and help land on a decision/path forward
- [name=Gabriel] In response to this question, there was discussion and questions around Notebook 7 vs JupyterLab
- Sylvain
- Notebook v7 audit by Balaji at UC Berkeley
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
## November 30 2022

### Attendees

- Mark
- Martha
- Gabriel
- JooYoung
- Tony
- Stephannie
- Mike
- Tania

### Agenda

- Gabriel
- Discuss: "Jupyter Accessibility":
1. Group exercise: open your favorite search engine, type "Jupyter Accessibility"... where does it take you? what is the first thing you see?
2. Are we happy with this?
3. If not, what do we need to do?
[name=Tania] - we need docs like https://code.visualstudio.com/docs/editor/accessibility for Lab and friends
[name=Mike] - Collect a list of extensions and themes for accessibility features see https://jupyter-accessibility.readthedocs.io/en/latest/#using-jupyter-software-with-assistive-technology
Comments included that we don't have user-focused documentation to point to. Even if they live on a per project basis, it makes sense to also have them here.
- Some take-aways:
1. Keep jupyter/accessibility as one repo. Don’t split into two repos (one for user-facing docs, one for team compass)
2. Put sign posts for end users in jupyter/accessibility repo and website.
3. Try to add accessibility docs to jupyter.org and/or JupyterLab ReadTheDocs
4. Push forward the work done on the Accessibility statement, with an eye to providing useful info for disabled users.
5. Think about restructuring current docs so that they address different users: contributors, end users, maintainers, and such.
6. Repos that use the keyword accessibility but are incomplete or works in progress sohuld probably have some kind of WIP label and preamble.
- Links:
- [name=Mike] I opened a [PR to add link to accessibility docs on docs.jupyter.org](https://github.com/jupyter/jupyter/pull/665)
- [name=Tania] [Point accessibility.jupyter.org to these docs?](https://github.com/jupyter/accessibility/discussions/109)

- Isabela
- Summary of Space Telescope user testing results for test 1: navigation. [Results slides](https://docs.google.com/presentation/d/1rSrPlK-dW49h0LorSTMEMpLRfOkR2aUak4HAHKAPjK8/edit?usp=sharing). [Full results](https://github.com/Iota-School/notebooks-for-all/blob/main/user-tests/1-navigation/results.md).
- Want to fix the broken link to our old meeting notes? Help with [jupyter/accessibility #113](https://github.com/jupyter/accessibility/issues/113) is welcome!
- I want to review and (if needed) update the [accessibility project board](https://github.com/orgs/jupyterlab/projects/1) soon. Is anyone interested in giving this a review as well? We can split issues up to save time.
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
## December 14 2022

### Attendees

- Min
- Darian
- Ryan
- tonyfast
- Blessing Ogoh
- Gabriel
- Isabela

## Agenda

- Isabela
- Calendar check. Is this our last meeting of the year?
- [name=Gabriel] FYI, the JupyterLab team meeting on Dec 28 that precedes this one was cancelled.
- Want to fix the broken link to our old meeting notes? Help with [jupyter/accessibility #113](https://github.com/jupyter/accessibility/issues/113) is welcome!
- [name=Min] my first accessibility PR! https://github.com/jupyter/accessibility/pull/115
- I want to review and (if needed) update the [accessibility project board](https://github.com/orgs/jupyterlab/projects/1) soon. Is anyone interested in giving this a review as well? We can split issues up to save time.

- Gabriel
- In the meeting before this one, Florence from QuantStack demo'd a JupyterLab extension to edit the look and feel of JupyterLab.
- [name=Ryan] Sounds like it could lead to accessible themes or maybe more accessible defaults
- [name=Gabriel] Yes! but for me the key thing that interests me here in terms of accessibility for end users is empowering end users to customize the UI to their particular accessibility needs (high contrast, color blindness, large font, etc.)

- Min
- Connecting Blessing, Outreachy intern working on accessibility in JupyterHub
- Authentication, Spawning, Admin pages
- Wave exposing existing color/contrast issues
- How to make intentional design decisions

- Darian
- Wanted to open a PR against @steff456's [Lumino PR for collapsing menus](https://github.com/jupyterlab/lumino/pull/489)

- tony
- Progress on navigating static notebooks after a recent round of tests.
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,25 @@
```

````{include} 2022-01-26.md
```{include} 2022-01-26.md
```

```{include} 2022-02-09.md
```

```{include} 2022-02-23.md
```

```{include} 2022-03-09.md
```

```{include} 2022-03-23.md
````
```

```{include} 2022-04-06.md
Expand Down Expand Up @@ -54,3 +63,31 @@
```{include} 2022-09-07.md
```

```{include} 2022-09-21.md
```

```{include} 2022-10-05.md
```

```{include} 2022-10-19.md
```

```{include} 2022-11-02.md
```

```{include} 2022-11-16.md
```

```{include} 2022-11-30.md
```

```{include} 2022-12-14.md
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
## January 11, 2023

### Attendees

- Tony
- Gabriel
- Darian
- Isabela
- Mike
- Ryan
- Ely

## Agenda

- Accessible tables with pandas output https://tonyfast.github.io/tonyfast/xxiii/2023-01-02-accessible-dataframes-basic-indexes.html

- Darian: I am reviewing [Stephannie's menubar collapsing PR](https://github.com/jupyterlab/lumino/pull/489)
- darian is review this week.
- it is hard to know the size of something before it is rendered
- completer that measure width https://github.com/jupyterlab/jupyterlab/pull/13663
- Mike:
- should we try to turn on `screenReaderMode` in terminal (xterm.js) or is it fine to keep it off by default
- does anyone has time to provide a review for https://github.com/jupyterlab/lumino/pull/477?
- [jupyterlab # 13704 cell role](https://github.com/jupyterlab/jupyterlab/issues/13704)
- related reading: [aria-label is a code smell](https://ericwbailey.website/published/aria-label-is-a-code-smell/)

## Non-agenda
- What Gabriel is currently working on
- JupyterLab PR: [Make file browser respond to focused elements #13577](https://github.com/jupyterlab/jupyterlab/pull/13577)
- [Tab trap in JupyterLab notebook code cell](https://github.com/Quansight-Labs/jupyter-a11y-mgmt/issues/168)
- post meeting: I believe Darian asked during the meeting if someone had done some a11y testing of Google Colab. I found out later that Balaji Alwar did this, using a public notebook. Result is at https://user-images.githubusercontent.com/2306166/197913587-bbae1601-d0f4-436b-bd83-6d2ea8892753.png.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
## January 25, 2023

### Attendees

| Name | Affiliation | GitHub | Favorite html tag |
| ------------------ | ----------- | ------------- | ------------------------------ |
| tony fast | | @tonyfast | details |
| Tania Allard | Quansight Labs | @trallard | `<abbr>`|
| Stephannie Jimenez Gacha | Quansight Labs | @steff456 | |
| Martha Cryan | IBM | @marthacryan | |
| Gabriel Fouasnon | Quansight Labs | @gabalafou | `<script>` but doing this exercise, I learned about the `<progress>` tag |
| Michal Krassowski | Quansight | @krassowski | |
| Isabela Presedo-Floyd | Quansight Labs | @isabela-pf | `<p>` |
| | | | |

## Agenda

* progress on testing static notebooks. [notebooks for all testing content](https://iota-school.github.io/notebooks-for-all/)
* how we parameterize notebooks with the jupyter configs.
* [rendering dataframes for screen readers with pandas](https://tonyfast.github.io/tonyfast/xxiii/2023-01-02-accessible-dataframes-basic-indexes.html)
* https://adrianroselli.com/2017/11/a-responsive-accessible-table.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## February 8 2023

### Attendees

| Name | Affiliation | GitHub | Favorite aria role |
| ------------------ | ----------- | ------------- | ------------------------------ |
| tony fast | | @tonyfast | [feed](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/feed_role) |
|william stein | SageMath, Inc | @williamstein | |
| a. t. darian | `quantstack` | @afshin | `complementary` |
| Gabriel Fouasnon | Quansight Labs | @gabalafou | |
| Stephannie Jimenez Gacha | Quansight labs | @steff456 | |
| R Ely | Bloomberg | @ohrely | Olympia (Les Contes d'Hoffmann) |

## Agenda

* [name=Gabriel] Possible office hours question: keyboard shortcuts registered via the JupyterLab command registry are handled on the capture phase, but I have always worked in apps that use bubbling.
* Why are keyboard shortcuts implemented how they are?
* chord shortcuts were applied. it is a emacs feature. helps entice emacs users in jupyter.
* support chords
* css specificity
* people implement their own keyboard action when it is not a command.
* use case: a mini list to make up down l r work.
* How are keyboard shortcuts handled?
* keyboard shortcuts are composed and executed by the command registry.
* this happens at the lumino application layer.
* [specificity versus matchability](https://github.com/jupyterlab/jupyterlab/blob/b7c241483ec8562eb2a836ebc86086d04597aa4a/packages/shortcuts-extension/src/index.ts#L51-L79)
* [name=william] A little motivated by Darian's comment last hour: I'm curious about the accessibility implications of being able to move buttons around in toolbars, reorder menus, etc. It can be confusing because customization has a scope with web apps that is a lot different than say "photoshop".
* [name=tonyfast] semantic tags for notebooks and cells
* Could a [rendered notebook (static HTML page) be described by aria role=feed](https://iota-school.github.io/notebooks-for-all/exports/Imaging_Sky_Background_Estimation-form-based.html)?
Loading

0 comments on commit 7b8d0bb

Please sign in to comment.