Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added main/navigation tags to meet DAP requirements: issue #3217 #4734

Merged
merged 5 commits into from
Jul 11, 2019

Conversation

joshuazeltser
Copy link
Contributor

Fixed issue #3217. Ran the Dynamic Assessment Plugin and fixed some of the errors caused by missing regions by adding main and navigation roles to the tree.html page. The lang attribute error does not seem to appear for us.

added main and navigation tags to tree and page.html
Copy link
Contributor

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left a comment about localization. This might affect almost all you PRs...

notebook/templates/page.html Outdated Show resolved Hide resolved
@joshuazeltser
Copy link
Contributor Author

I have added the relevant tags

@takluyver takluyver added this to the 6.0 milestone Jul 11, 2019
@takluyver takluyver dismissed yuvipanda’s stale review July 11, 2019 10:07

Localisation fixed

@takluyver takluyver merged commit 416b7d7 into jupyter:master Jul 11, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants