Reduce code duplication #5278
Reduce code duplication #5278
Conversation
|
Closed and reopened pull request to trigger CI rebuild |
| try: | ||
| fileobj = open_file(path, text, encoding, log, **kwargs) |
There was a problem hiding this comment.
To preserve the original integrity, this should occur prior to the try block, otherwise you need to protect the fileobj.close() call since fileobj will be None if open_file() throws an exception.
|
|
||
| try: | ||
| fileobj = open_file(path, text, encoding, log, **kwargs) |
There was a problem hiding this comment.
Same comment as above regarding fileobj being None in exception block.
| Passed to :func:`io.open`.""" | ||
|
|
||
| if os.path.islink(path): | ||
| path = os.path.join(os.path.dirname(path), os.readlink(path)) |
There was a problem hiding this comment.
This if block shouldn't be part of the reduction since this same code exists in atomic_writting() with dependent code in between.
blink1073
added
status:Needs Info
status:Waiting for Author
and removed
status:Needs Info
labels
|
Closing as the maintained server code now lives in the Jupyter Server repo: https://github.com/jupyter-server/jupyter_server @mikebeijen please open a PR in https://github.com/jupyter-server/jupyter_server if you think this change is still applicable. Thanks! |
Removes duplicated code