Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @jupyterlab/galata #7361

Merged
merged 18 commits into from
May 14, 2024
Merged

Update @jupyterlab/galata #7361

merged 18 commits into from
May 14, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 13, 2024

Update @jupyterlab/galata to match the latest JupyterLab 4.2.0 release.

Might need some tricks from jupyterlab/jupyterlab#15621

Also make some changes to try to reduce the UI tests flakyness.

@jtpio jtpio added this to the 7.2.0 milestone May 13, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/update-galata

@jtpio
Copy link
Member Author

jtpio commented May 13, 2024

bot please update playwright snapshots

@jtpio jtpio marked this pull request as ready for review May 14, 2024 09:10
@@ -29,7 +29,7 @@ repos:
rev: 'v2.2.6'
hooks:
- id: codespell
args: ['-L', 'hart,noteable']
args: ['-L', 'hart,noteable', '--skip', "*.spec.ts"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like afterAll makes the pre-commit check fail: https://results.pre-commit.ci/run/github/33653601/1715676598.F47qygP7RKuJagZupcWLmA

image

Adding afterAll to the list of ignored words (via -L) does not seem to help, but skipping all .spec.ts files does. Might be worth investigating more in a separate issue or PR.

@jtpio
Copy link
Member Author

jtpio commented May 14, 2024

For reference it looks like we still have some flakiness with the notebook toolbar sometimes missing the overflow button menu:

image

cc @brichet who looked into the notebook toolbar recently (as part of #7311) and may know if that might also be happening in JupyterLab.

@jtpio
Copy link
Member Author

jtpio commented May 14, 2024

For reference it looks like we still have some flakiness with the notebook toolbar sometimes missing the overflow button menu:

We can track that in a separate issue.

@jtpio jtpio merged commit 08fe5c5 into jupyter:main May 14, 2024
31 checks passed
@jtpio jtpio deleted the update-galata branch May 14, 2024 13:46
@jtpio jtpio mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant