Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for unix_socket #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jhgoebbert
Copy link

This PR enables RStudio connections via sockets in combination with this PR for RStudio rstudio/rstudio#14938

@jhgoebbert
Copy link
Author

jhgoebbert commented Jul 8, 2024

This PR also

  • adds www-thread-pool-size as a possible option which can be set via the environment variable RSERVER_THREAD_POOL_SIZE
  • calls rserver just once to get all supported arguments in _support_args(). This is useful as rserver might be only available through modules which takes some time to load. Therefore, this loading can be reduced.

@yuvipanda
Copy link
Contributor

yay, thank you for your contribution both here and upstream to rstudio! This is going to unlock a lot of non-containerized use cases - I'm super excited for that to land :)

If you could split the PR into a unix socket one and one with everything else, that would make this easier to review and merge. I would like to hold off on merging the unix socket one until that upstream PR gets merged, but the others should be easier. Would you be open to splitting it up like that?

Thanks!

@jhgoebbert
Copy link
Author

jhgoebbert commented Jul 23, 2024

Thanks @yuvipanda . I will split the PR.

The PR for unix-socket support in RStudio is now merged and will be part of the official "Kousa Dogwood" builds expected in 2024.10 : rstudio/rstudio#14938 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants