Propagate scroll from backdrop #652

krassowski · 2023-10-28T15:09:53Z

makes the .lm-cursor-backdrop scrollable using a pseudo-element and stlyes, but hiding the scrollbar
propagates intercepted scroll events to relevant element with data-lm-dragscroll property
adds top/left to .lm-cursor-backdrop as in Add default top/left for .lm-mod-drag-image #651

Restoring scrolling in browser when dragging cells:

Once jupyterlab/jupyterlab#15318 is in, also enables scrolling in file browser with selection

None

packages/dragdrop/src/index.ts

fcollonval

I only have a small suggestion.

krassowski added 3 commits October 28, 2023 15:06

Propagate scrolling from backdrop to scroll target

3c074d7

Add a test case for scroll propagation

4c038d3

Ensure the scroll works through longer ranges

8cc5b45

krassowski added the bug Something isn't working label Oct 28, 2023

github-actions bot assigned krassowski Oct 28, 2023

krassowski mentioned this pull request Oct 28, 2023

Implement tab scrolling on tabbar #297

Open

6 tasks

fcollonval reviewed Oct 30, 2023

View reviewed changes

packages/dragdrop/src/index.ts Outdated Show resolved Hide resolved

fcollonval approved these changes Oct 30, 2023

View reviewed changes

Fix a typo in a private function

6b74eae

krassowski merged commit f4e065b into jupyterlab:main Oct 30, 2023
17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024

Provide feedback