Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dynamic keyboard event mode #653

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Remove dynamic keyboard event mode #653

merged 2 commits into from
Oct 31, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Oct 30, 2023

This PR is a follow up of #635, to remove an experimental implementation.

The keyboard event mode cannot be dynamically set up anymore, only when the application starts.

@brichet brichet added accessibility Addresses accessibility needs deprecation Deprecate code labels Oct 30, 2023
@fcollonval fcollonval added the enhancement New feature or request label Oct 30, 2023
krassowski
krassowski approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

fcollonval
fcollonval approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit c94ef4d into jupyterlab:main Oct 31, 2023
17 checks passed
@brichet brichet deleted the dynamic-event-phase branch November 3, 2023 06:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

@krassowski krassowski krassowski approved these changes

Assignees

@brichet brichet

Labels
accessibility Addresses accessibility needs deprecation Deprecate code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brichet @krassowski @fcollonval