Extract plugin handling in a PluginRegistry class independent of the Application
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Zsailer |
fcollonval
force-pushed
the
ft/extract-plugin-handling
branch
from
eb66b9b
to
6f0a921
Compare
brichet
reviewed
May 23, 2024
There was a problem hiding this comment.
Thanks @fcollonval, LGTM, at least everything work in a dev installation.
I just have a few comments.
packages/coreutils/src/typing.d.ts
Outdated
There was a problem hiding this comment.
Out of curiosity, why do we need this ?
Should it be defined in other packages using console ?
There was a problem hiding this comment.
This package is compatible for browser and nodejs environment.
The automatic way to make TypeScript happy is to mention in the tsconfig that the target is DOM. However node js does not implement all the DOM API. But it does implement the console. So this pleases TypeScript but prevent future change to reference for example window or document (not available in node js).
Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
|
Thanks for the review @brichet |
brichet
approved these changes
May 24, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697
Fixes #586
Refactor the plugins handling outside of the
Applicationclass to be able to instantiate and use it independently.Add a allowed/blocked list feature to the new class.
The new
PluginRegistryclass is defined in coreutils to avoid bringing the widgets package in the stack dependency of the plugin system consumer. That implies adding the algorithm package as dependency to coreutils.