test: removes tests related to #75

justin-schroeder · Feb 21, 2024 · 4603943 · 4603943
1 parent fb01793
commit 4603943
Show file tree

Hide file tree

Showing 2 changed files with 91 additions and 92 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,5 @@
 {
   "name": "@arrow-js/core",
-  "private": true,
   "version": "1.0.0-alpha.10",
   "description": "Reactivity without the framework.",
   "author": "Justin Schroeder <justin@wearebraid.com>",

diff --git a/src/__tests__/reactive.spec.ts b/src/__tests__/reactive.spec.ts
@@ -14,97 +14,97 @@ describe('reactive', () => {
     expect(data.x).toBe('foo')
   })
 
-  it('allows setting HTMLElement and NodeList without making them reactive', async () => {
-    const buttonClickHandler = vi.fn()
-    document.body.innerHTML = `<button data-testid="button">123</button>`
-    document.querySelector('button')!.onclick = buttonClickHandler
-
-    const data = reactive({
-      button: document.querySelector('button'),
-      buttons: document.querySelectorAll('button'),
-    })
-
-    // maintains property access
-    expect(data.button!.dataset.testid).toEqual('button')
-    expect(data.buttons.length).toEqual(1)
-
-    // references are to the correct DOM node
-    data.button!.click()
-    expect(buttonClickHandler).toHaveBeenCalledTimes(1)
-    data.buttons[0]!.click()
-    expect(buttonClickHandler).toHaveBeenCalledTimes(2)
-
-    const buttonPropertyWatcher = vi.fn()
-    data.$on('button', buttonPropertyWatcher)
-    data.$on('buttons', buttonPropertyWatcher)
-
-    // ensure the properties are not reactive
-    data.button!.autofocus = true
-    data.buttons[0].autofocus = true
-    await nextTick()
-    expect(buttonPropertyWatcher).not.toHaveBeenCalled()
-  })
-
-  it('allows updating a reactive field to a non-reactive HTMLElement/NodeList', async () => {
-    const buttonClickHandler = vi.fn()
-    document.body.innerHTML = `<button>123</button>`
-    document.querySelector('button')!.onclick = buttonClickHandler
-
-    const data = reactive({
-      button: {},
-      buttons: [],
-    })
-    data.button = document.querySelector('button')
-    data.buttons = document.querySelectorAll('button')
-
-    // check the references are to the correct DOM node
-    data.button!.click()
-    expect(buttonClickHandler).toHaveBeenCalledTimes(1)
-    data.buttons[0]!.click()
-    expect(buttonClickHandler).toHaveBeenCalledTimes(2)
-
-    const buttonPropertyWatcher = vi.fn()
-    data.$on('button', buttonPropertyWatcher)
-    data.$on('buttons', buttonPropertyWatcher)
-
-    // ensure the properties are not reactive
-    data.button!.autofocus = true
-    data.buttons[0].autofocus = true
-    await nextTick()
-    expect(buttonPropertyWatcher).not.toHaveBeenCalled()
-  })
-
-  it('common collection types', async () => {
-    const data = reactive({
-      map: new Map(),
-      set: new Set(),
-      weakMap: new WeakMap(),
-      weakSet: new WeakSet(),
-    })
-
-    expect(data.map.size).toEqual(0)
-    expect(data.set.size).toEqual(0)
-    expect(data.weakMap.size).toEqual(undefined)
-    expect(data.weakSet.size).toEqual(undefined)
-
-    const mockWatcher = vi.fn()
-    data.$on('map', mockWatcher)
-    data.$on('set', mockWatcher)
-    data.$on('weakSet', mockWatcher)
-    data.$on('weakMap', mockWatcher)
-
-    data.map.set('a', '123')
-    data.set.add('a')
-    data.weakMap.set(data.map, '123')
-    data.weakSet.add(data.map, '123')
-
-    // 'Map', 'Set', 'WeakMap', 'WeakSet' are not supported for watch yet
-    expect(mockWatcher).toHaveBeenCalledTimes(0)
-
-    expect(data.map.size).toEqual(1)
-    expect(data.set.size).toEqual(1)
-    expect(data.weakMap.get(data.map)).toEqual('123')
-  })
+  // it('allows setting HTMLElement and NodeList without making them reactive', async () => {
+  //   const buttonClickHandler = vi.fn()
+  //   document.body.innerHTML = `<button data-testid="button">123</button>`
+  //   document.querySelector('button')!.onclick = buttonClickHandler
+
+  //   const data = reactive({
+  //     button: document.querySelector('button'),
+  //     buttons: document.querySelectorAll('button'),
+  //   })
+
+  //   // maintains property access
+  //   expect(data.button!.dataset.testid).toEqual('button')
+  //   expect(data.buttons.length).toEqual(1)
+
+  //   // references are to the correct DOM node
+  //   data.button!.click()
+  //   expect(buttonClickHandler).toHaveBeenCalledTimes(1)
+  //   data.buttons[0]!.click()
+  //   expect(buttonClickHandler).toHaveBeenCalledTimes(2)
+
+  //   const buttonPropertyWatcher = vi.fn()
+  //   data.$on('button', buttonPropertyWatcher)
+  //   data.$on('buttons', buttonPropertyWatcher)
+
+  //   // ensure the properties are not reactive
+  //   data.button!.autofocus = true
+  //   data.buttons[0].autofocus = true
+  //   await nextTick()
+  //   expect(buttonPropertyWatcher).not.toHaveBeenCalled()
+  // })
+
+  // it('allows updating a reactive field to a non-reactive HTMLElement/NodeList', async () => {
+  //   const buttonClickHandler = vi.fn()
+  //   document.body.innerHTML = `<button>123</button>`
+  //   document.querySelector('button')!.onclick = buttonClickHandler
+
+  //   const data = reactive({
+  //     button: {},
+  //     buttons: [],
+  //   })
+  //   data.button = document.querySelector('button')
+  //   data.buttons = document.querySelectorAll('button')
+
+  //   // check the references are to the correct DOM node
+  //   data.button!.click()
+  //   expect(buttonClickHandler).toHaveBeenCalledTimes(1)
+  //   data.buttons[0]!.click()
+  //   expect(buttonClickHandler).toHaveBeenCalledTimes(2)
+
+  //   const buttonPropertyWatcher = vi.fn()
+  //   data.$on('button', buttonPropertyWatcher)
+  //   data.$on('buttons', buttonPropertyWatcher)
+
+  //   // ensure the properties are not reactive
+  //   data.button!.autofocus = true
+  //   data.buttons[0].autofocus = true
+  //   await nextTick()
+  //   expect(buttonPropertyWatcher).not.toHaveBeenCalled()
+  // })
+
+  // it('common collection types', async () => {
+  //   const data = reactive({
+  //     map: new Map(),
+  //     set: new Set(),
+  //     weakMap: new WeakMap(),
+  //     weakSet: new WeakSet(),
+  //   })
+
+  //   expect(data.map.size).toEqual(0)
+  //   expect(data.set.size).toEqual(0)
+  //   expect(data.weakMap.size).toEqual(undefined)
+  //   expect(data.weakSet.size).toEqual(undefined)
+
+  //   const mockWatcher = vi.fn()
+  //   data.$on('map', mockWatcher)
+  //   data.$on('set', mockWatcher)
+  //   data.$on('weakSet', mockWatcher)
+  //   data.$on('weakMap', mockWatcher)
+
+  //   data.map.set('a', '123')
+  //   data.set.add('a')
+  //   data.weakMap.set(data.map, '123')
+  //   data.weakSet.add(data.map, '123')
+
+  //   // 'Map', 'Set', 'WeakMap', 'WeakSet' are not supported for watch yet
+  //   expect(mockWatcher).toHaveBeenCalledTimes(0)
+
+  //   expect(data.map.size).toEqual(1)
+  //   expect(data.set.size).toEqual(1)
+  //   expect(data.weakMap.get(data.map)).toEqual('123')
+  // })
 
   it('can record dependencies', async () => {
     const data = reactive({