Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version 16 > 20 #3

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update nodejs version 16 > 20 #3

merged 1 commit into from
Sep 23, 2024

Conversation

jixxed
Copy link
Contributor

@jixxed jixxed commented Sep 20, 2024

What

Updates NodeJS version

Why

because 16 is no longer supported and 20 is the current version for lambda

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@jixxed jixxed requested a review from JoostSaanen September 20, 2024 08:57
@jixxed jixxed merged commit 5dce5be into main Sep 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants