Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales and added missing ones acording ebird suported locales #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wiliamsouza
Copy link
Contributor

@wiliamsouza wiliamsouza commented May 10, 2024

I was looking for Brazilian portuguese pt_BR locales because the pt were not working.
But instead only add pt_BR or fix pt maybe adding support to missing locales can help others.
With that in mind this PR add support to all availabe names listed here.

What do you think about document this locales on readme file?

@Josef-Haupt
Copy link
Collaborator

Hey thanks for wour work!
These are a lot of files though, I'm not sure if all of them contain a relevant number of translations. Could you check of all of these translations contain atleast 10 percent translated labels? Compared to the en default labels.

@wiliamsouza
Copy link
Contributor Author

wiliamsouza commented May 15, 2024

I used the following script:

#!/bin/bash
# Measures file difference percentage 
# First install wdiff
# sudo apt install wdiff

for filename in *.txt; do
    [ -e "$filename" ] || continue
        wdiff -s BirdNET_GLOBAL_6K_V2.4_Labels_en.txt $filename | tail -2
        echo "--------------------------------------------------------------------------------"
done

This is the result percentage.txt

@Josef-Haupt
Copy link
Collaborator

Thank you, but could you do the comparison on a line by line basis? It's nice to have more languages, but we want to limit the number of label files in the repository to a certain number, that still leaves the option for users to add more languages locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants