-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[src] Modified mel computations (cleaned up version) #3165
base: master
Are you sure you want to change the base?
Conversation
…s activated using --modified option.
…fied-mel-kaldi
…into pegahgh-modified-mel-kaldi
This is supposed to give a small but consistent performance improvement correct? |
Yes. I'd say around 0.2 to 0.3% absolute on average (at least when the WER
is in the 20 to 30% range). It needs some more testing before I'm ready to
merge it. Of course if you want to help, that's great.
…On Mon, Mar 25, 2019 at 9:00 AM Rudolf A. Braun ***@***.***> wrote:
This is supposed to give a small but consistent performance improvement
correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3165 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJVu0X4FSGLo407ljIiEwtllhONQoXgks5vaMiLgaJpZM4cFx2K>
.
|
And by testing, I am talking about the effect on WER, not just does it run.
…On Mon, Mar 25, 2019 at 10:40 AM Daniel Povey ***@***.***> wrote:
Yes. I'd say around 0.2 to 0.3% absolute on average (at least when the
WER is in the 20 to 30% range). It needs some more testing before I'm
ready to merge it. Of course if you want to help, that's great.
On Mon, Mar 25, 2019 at 9:00 AM Rudolf A. Braun ***@***.***>
wrote:
> This is supposed to give a small but consistent performance improvement
> correct?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#3165 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADJVu0X4FSGLo407ljIiEwtllhONQoXgks5vaMiLgaJpZM4cFx2K>
> .
>
|
I could do a build on my own data (so you'd have to take my word for the results), if that works for you? |
Yes, that works for me.
…On Tue, Mar 26, 2019 at 8:51 AM Rudolf A. Braun ***@***.***> wrote:
I could do a build on my own data (so you'd have to take my word for the
results), if that works for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3165 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJVuzTcXb0l21aXMGdn85kBTN76gxqIks5vahfjgaJpZM4cFx2K>
.
|
src/feat/mel-computations.cc
Outdated
high_freq_ : center_freqs_(bin + 1)); | ||
|
||
BaseFloat d1 = (next_center - center_freq) * 1.1, | ||
d2 = 60.0 + 50.0 * (center_freq / (center_freq + 700.0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be breakpoint_ instead of 700.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of making this a separate issue from the breakpoint, so that when we tune it it doesn't have to have the same value. Can you compare 700 with 300 (our current breakpoitn) in your new experiments? If 300 works better we can reconsider.
Sorry about the delay on this: Some info about the model: 100h with 13 layer tdnnf. No ivector. Decoding with a 1M ngram language model (no rescoring). Because of how my data is acquired, I cannot always guarantee that there is no overlap in speakers between training/test, these are the test sets A, B, C. Some test sets I can guarantee it, those are X, Y, Z
As can see from the results it seems the modified version overfits more. |
Great, thanks. It turns out there may have been a problem with that particular code (i.e. there was a mismatch to what it should have been), although I don't know how important that actually was. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed by a bot strictly because of inactivity. This does not mean that we think that this issue is not important! If you believe it has been closed hastily, add a comment to the issue and mention @kkm000, and I'll gladly reopen it. |
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open. |
to be tested. Would be activated by setting
modified=true
in conf/mfcc_hires.conf