Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13420): support modifying start and end time of video #658

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Oct 10, 2023

Description of the Changes

  • Support new configurations: seekFrom and clipTo.
  • If configured, chain the values to the playManifest request in order to cut the video.
  • Also support cutting the thumbSprite accordingly

related PR- kaltura/playkit-js#724

Solves FEC-13420

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

lianbenjamin added a commit to kaltura/playkit-js that referenced this pull request Oct 10, 2023
### Description of the Changes

add new configurations under `PKSourcesConfigObject` object:
- `seekFrom` - optional, number, in sec
- `clipTo` - optional, number, in sec

if configured, the above will be chained to the `playManifest` request and as a result, the video will play from the seekFrom position to the clipTo position.

**For example:**
configuring the following: `seekFrom=10`, `clipTo=20`, where the video duration is 40 sec.
the duration of the video that will be played as a result, would be 10 sec long, where the first frame will be the same as the frame of the original video at position 10; and the end frame will be the same as the frame of the original video at position 20.

**related PR-** kaltura/kaltura-player-js#658

Solves FEC-13420
@lianbenjamin lianbenjamin merged commit e53698e into master Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants