fix(SUP-43445): Chapter markers does not appear in player scrubber #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Jul 7, 2024
SivanA-Kaltura
requested changes
Jul 7, 2024
SivanA-Kaltura
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
Chapter markers doesn't appear on the seekbar on live entry (that currently not broadcasting)
Root cause:
The marker displaying depend on duration promise, if duration from engine and player is not the same, the marker won't be displayed.
souces.duration on the player contains the live duration and not the vod duration so in case the vod duration different from the live duration comparing the engine and source.duartion always returns false.
Fix:
If this is live entry but currently not broadcasting and vod is going to play, change the source.duration to the vod duration.
Resolves SUP-43445