Merge pull request RocketChat#78 from Prince-Mendiratta/main

feat: show proper description in command preview
kanishbodhwani · Mar 27, 2023 · cdf7f8a · cdf7f8a
2 parents 75b0641 + c3c7c9a
commit cdf7f8a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/github/commands/GhCommand.ts b/github/commands/GhCommand.ts
@@ -15,7 +15,7 @@ export class GHCommand implements ISlashCommand {
     public constructor(private readonly app: GithubApp) {}
     public command: string = "gh";
     public i18nParamsExample: string = "";
-    public i18nDescription: string = "fetching github data";
+    public i18nDescription: string = "cmd_description";
     public providesPreview: boolean = false;
 
     public async executor(

diff --git a/github/commands/GithubCommand.ts b/github/commands/GithubCommand.ts
@@ -15,7 +15,7 @@ import { CommandUtility } from "../lib/commandUtility";
 export class GithubCommand implements ISlashCommand {
     public constructor(private readonly app: GithubApp) {}
     public command = "github";
-    public i18nDescription = "fetching github data";
+    public i18nDescription = "cmd_description";
     public providesPreview = false;
     public i18nParamsExample = "";
 

diff --git a/github/i18n/en.json b/github/i18n/en.json
@@ -0,0 +1,3 @@
+{
+    "cmd_description": "Search, Share, Review, Merge, Subscribe GitHub Resources and do much more from Rocket.Chat."
+}