Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug #4

wants to merge 2 commits into from

Conversation

hiroakis
Copy link
Member

@hiroakis hiroakis commented Dec 26, 2018

Not works if formats include , in /.../ literal. The related issue #3

@hiroakis hiroakis changed the title Fix bug #3 Fix bug https://github.com/kanmu/fluent-plugin-pan-anonymizer/issues/3 Dec 26, 2018
@hiroakis hiroakis changed the title Fix bug https://github.com/kanmu/fluent-plugin-pan-anonymizer/issues/3 Fix bug Dec 26, 2018
@hiroakis hiroakis requested a review from mururu December 26, 2018 11:53
@hiroakis hiroakis added the bug Something isn't working label Dec 26, 2018
@hiroakis hiroakis self-assigned this Dec 26, 2018
@@ -20,8 +20,13 @@ def initialize
def configure(conf)
super

formats = conf.each_element.map do |i|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't enough to check @pan_configs? I think formats directives are only in <pan> section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fluentd can't parse a regexp array correctly.

@cameronattard
Copy link

Has this PR been abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants