-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the unnecessary file localization steps when karmadactl register #5862
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5862 +/- ##
==========================================
+ Coverage 46.31% 46.35% +0.04%
==========================================
Files 661 663 +2
Lines 54364 54524 +160
==========================================
+ Hits 25177 25273 +96
- Misses 27562 27627 +65
+ Partials 1625 1624 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @zhzhuang-zju, sorry for the delay in reviewing the PR. I haven't had the chance to review it yet. I’ll give it a full review today. 🙏 |
It's okay, just go at your own pace. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @zhzhuang-zju! LGTM 🎉 A small tweak that resolves a few issues—well done! 👌 I'll follow up on the PR for the E2E tests of the register command (#5334) after this PR is merged.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mohamedawnallah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
When executing the
karmadactl register
command, there are many localized file operations involved, which lead to the following issues:karmadactl register
fails, the residual files can cause the next execution ofkarmadactl register
to fail.In fact, the file localization steps in
karmadactl register
are unnecessary and can be removed.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
If we want to use
karmadactl register
in CI to join a pull mode cluster, it will fail due to lack ofroot
permissions.https://github.com/karmada-io/karmada/actions/runs/11608077257/job/32322805939?pr=5763#step:5:934
Does this PR introduce a user-facing change?: