add mci finalizer with patch operation

[XiShanYongYe-Chang]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In large-scale scenarios, when a large number of MCI objects are created in a short period of time, errors will occur more frequently: the object has been modified please apply your changes to the latest version and try again. It caused an error in adding the finalizer and re-entering the queue to wait for reconcile. However, due to the large number of elements in the queue, the current queuing time of the elements is longer. long.

So add mci finalizer with patch operation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[RainbowMango]

It caused an error in adding the finalizer and re-entering the queue to wait for reconcile.

Can you provide a log? I'd like to see which line of code conflicts.

[RainbowMango]

@XiShanYongYe-Chang It is quite suspicious that the conflict occurred at the beginning of the reconcile process.
Shall we open an issue to track this problem?

[XiShanYongYe-Chang]

This problem does not occur when the code on the master branch is used for local build and test. It occurs during secondary development of a third-party platform.

[RainbowMango]

This problem does not occur when the code on the master branch is used for local build and test. It occurs during secondary development of a third-party platform.

Yeah. We can't control how the cloud provider implements or modifies the MCI objects. From this perspective, we can move this forward.

[XiShanYongYe-Chang]

This place update the MultiClusterIngress object:

multicluster-cloud-provider/pkg/controllers/mciservicelocations/mci_service_locations.go

Line 63 in 1207b03

updateErr := c.Client.Status().Update(ctx, mci)

This make a conflict with the mci-controller add finalizer. The relate log for controller is that:

mci_service_locations.go:81] Success to sync multiClusterIngress(demo/mci-100) service locations
serviceexport_propagation_controller.go:124] "service's cluster results" namespace="demo" name="service-100" clusters=["xxx","ttt"]
mci_controller.go:98] "failed to update mci with finalizer" err="Operation cannot be fulfilled on multiclusteringresses.networking.karmada.io \"mci-100\": the object has been modified; please apply your changes to the latest version and try again" namespace="demo" name="mci-100"
controller.go:329] "Reconciler error" err="Operation cannot be fulfilled on multiclusteringresses.networking.karmada.io \"mci-100\": the object has been modified; please apply your changes to the latest version and try again" controller="multiclusteringress-controller" object="demo/mci-100" namespace="demo" name="mci-100" reconcileID="b6529093-571f-4648-8bae-5ba1347ce448"

[RainbowMango]

Great! Now we have enough confidence to move this forward.

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment