-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mci finalizer with patch operation #18
add mci finalizer with patch operation #18
Conversation
Can you provide a log? I'd like to see which line of code conflicts. |
Signed-off-by: changzhen <changzhen5@huawei.com>
a86c95a
to
d4fab7f
Compare
@XiShanYongYe-Chang It is quite suspicious that the conflict occurred at the beginning of the reconcile process. |
|
Yeah. We can't control how the cloud provider implements or modifies the MCI objects. From this perspective, we can move this forward. |
This place update the MultiClusterIngress object: multicluster-cloud-provider/pkg/controllers/mciservicelocations/mci_service_locations.go Line 63 in 1207b03
This make a conflict with the mci-controller add finalizer. The relate log for controller is that:
|
Great! Now we have enough confidence to move this forward. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In large-scale scenarios, when a large number of MCI objects are created in a short period of time, errors will occur more frequently:
the object has been modified please apply your changes to the latest version and try again
. It caused an error in adding the finalizer and re-entering the queue to wait for reconcile. However, due to the large number of elements in the queue, the current queuing time of the elements is longer. long.So add mci finalizer with patch operation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: