Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOMP-217-progress #398

Merged
merged 4 commits into from
Aug 21, 2023
Merged

KOMP-217-progress #398

merged 4 commits into from
Aug 21, 2023

Conversation

adrianflatner
Copy link
Contributor

@adrianflatner adrianflatner commented Aug 14, 2023

Beskrivelse

Legger til dokumentasjon for Progress.

Screenshot 2023-08-14 at 15 45 35

Sjekkliste

@adrianflatner adrianflatner requested a review from a team as a code owner August 14, 2023 13:46
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: c92657f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@nilben nilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg ser du har feilende tester. Det skyldes at wcag krever at dette elementet blir brukt sammen med en label. I dokumentasjonen er vi jo opptatt av å vise selve elementet, og ikke labelen, men ta gjerne en titt på slider for å se på hvordan det er løst der.

),
};

export const ProgressAnimated: Story = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du kan kanskje putte en isAnimated også under animert, men bortsett fra det ser det helt glimrende ut 😁

@adrianflatner
Copy link
Contributor Author

Jeg ser du har feilende tester. Det skyldes at wcag krever at dette elementet blir brukt sammen med en label. I dokumentasjonen er vi jo opptatt av å vise selve elementet, og ikke labelen, men ta gjerne en titt på slider for å se på hvordan det er løst der.

Yes! Det hender jeg lager PRer uten at jeg har sjekket testene, men det fikses alltid😎 Jeg kan sørge for at jeg ikke lager PR før jeg har sjekket, så dere slipper å se på koden før den er helt ferdig😅

@adrianflatner adrianflatner added the chromatic Create build on chromatic label Aug 15, 2023
@adrianflatner adrianflatner merged commit 5c05011 into master Aug 21, 2023
3 checks passed
@adrianflatner adrianflatner deleted the KOMP-217-progress branch August 21, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromatic Create build on chromatic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants