Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komp-364-searchButtonText #661

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Komp-364-searchButtonText #661

merged 7 commits into from
Nov 30, 2023

Conversation

adrianflatner
Copy link
Contributor

Ender utformingen på search for å legge til muligheten for å legge til tekst på søkeknappen.

Endringer:

  • Legger til width i span på Icon for å sørge for at det ikke blir layout shift under lasting av Icon.
  • Fjerner left og right icon prop på Search (Breaking change - major changeset)
  • Legger til muligheten å legge til tekst på Search ved å bruke enten iconButton eller searchButton. Det var ikke mulig å bruke en av de på grunn av at de er utformet litt forskjellig.

Kan se litt rart ut i storybook når man bytter props fordi det er en padding som blir regnet ut på render.

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 1c82f03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kvib/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 28, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-30 08:50 UTC

@adrianflatner adrianflatner merged commit a09ac7f into master Nov 30, 2023
5 checks passed
@adrianflatner adrianflatner deleted the komp-364-searchButtonText branch November 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants