Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komp-370-timepicker #665

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Komp-370-timepicker #665

merged 7 commits into from
Dec 7, 2023

Conversation

adrianflatner
Copy link
Contributor

@adrianflatner adrianflatner commented Dec 4, 2023

Beskrivelse

Legger til nytt komponent: Timepicker 🎉

Timepickeren har tatt utgangspunkt i hvordan Spor (Vy) har laget timepicker.

Det innføres hooks fra adobe for å bruke dette komponentet. Jeg ser på det som fremtidig investering for å lage helt nye komponenter. Veldig mange gode hooks for utvikling av komplekse komponenter for designsystemer. Det er react-stately for komponent-states og react-aria for å lage tilgjengelige komponenter.

Sjekkliste

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 0991c30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kvib/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-07 13:44 UTC

Copy link
Contributor

@SebastianPMaro SebastianPMaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minuteInterval prop får veldig rar oppførsel hvis man putter inn en verdi høyere enn 60 (testet med 121 og da hoppet den av og til med 59 min). Du får sjekke om det finnes en lett fiks, men det kan sikkert itereres over.

@adrianflatner adrianflatner merged commit 6515b4c into master Dec 7, 2023
5 checks passed
@adrianflatner adrianflatner deleted the komp-370-timepicker branch December 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants