Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types #2040

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Types #2040

wants to merge 8 commits into from

Conversation

adamclayd
Copy link

Added types for typescript

@GitToTheHub
Copy link
Collaborator

Hi, please change the following:

  • Remove the changes on .gitignore & package.json
  • Add the new methods:
    • canScheduleExactAlarms(successCallback, scope)
    • openAlarmSettings(successCallback, scope)
    • openNotificationSettings(successCallback, scope)
    • As described in CHANGELOG.md
  • Squash everything to one commit

Thanks

@GitToTheHub
Copy link
Collaborator

Hi can you please make the changes? Otherwise I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamclayd @GitToTheHub