Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #53

Merged
merged 2 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ jobs:
run: |
pytest tests --capture=no
- name: Log in to Docker Hub
uses: docker/login-action@f4ef78c080cd8ba55a85445d5b36e214a81df20a
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Push image to DockerHub
run: |
docker push --all-tags
- name: where am I
run: |
pwd
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ runs/
*.zip
catboost_info/
.cache
/build/
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ENV PYTORCH_VERSION ${PYTORCH_VERSION}
COPY ./ /workspace/
WORKDIR /workspace/
RUN /opt/mamba/bin/python -m pip install --upgrade pip && \
/opt/mamba/bin/python -m pip install -e .[cv,cv_classification,cv_semantic,cv_detection,nlp,nlp_retrieval,tabular,tabular_classification,dev] && \
/opt/mamba/bin/python -m pip install -e .[cv,cv_classification,cv_semantic,cv_detection,nlp,nlp_retrieval,ml,dev] && \
/opt/mamba/bin/python -m pip install dvc dvc-gdrive && \
/opt/mamba/bin/python -m pip install -U timm

Expand Down
2 changes: 1 addition & 1 deletion theseus/base/metrics/confusion_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def plot_cfm(cm, ax, labels: List):
ax.set_xlabel("\nActual")
ax.set_ylabel("Predicted ")

ax.xaxis.set_ticklabels(labels)
ax.xaxis.set_ticklabels(labels, rotation=90)
ax.yaxis.set_ticklabels(labels, rotation=0)


Expand Down
6 changes: 3 additions & 3 deletions theseus/cv/classification/callbacks/gradcam_callback.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,17 @@ def on_validation_end(self, trainer: pl.Trainer, pl_module: pl.LightningModule):
# Vizualize Grad Class Activation Mapping and model predictions
LOGGER.text("Visualizing model predictions...", level=LoggerObserver.DEBUG)

images = last_batch["inputs"]
images = last_batch["inputs"].cpu()
targets = last_batch["targets"]
model.eval()

## Calculate GradCAM and Grad Class Activation Mapping and
model_name = model.model.name
model_name = model.name

try:
grad_cam = CAMWrapper.get_method(
name="gradcam",
model=model.model.get_model(),
model=model.get_model(),
model_name=model_name,
use_cuda=next(model.parameters()).is_cuda,
)
Expand Down
17 changes: 10 additions & 7 deletions theseus/cv/classification/callbacks/visualize_callback.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def on_sanity_check_start(
trainloader = pl_module.datamodule.trainloader
train_batch = next(iter(trainloader))
val_batch = next(iter(valloader))

try:
self.visualize_model(model, train_batch)
except TypeError as e:
Expand All @@ -59,16 +58,19 @@ def on_sanity_check_start(

@torch.no_grad()
def visualize_model(self, model, batch):

device = next(model.parameters()).device

# Vizualize Model Graph
LOGGER.text("Visualizing architecture...", level=LoggerObserver.DEBUG)
LOGGER.log(
[
{
"tag": "Sanitycheck/analysis/architecture",
"value": model.model.get_model(),
"value": model.get_model(),
"type": LoggerObserver.TORCH_MODULE,
"kwargs": {
"inputs": move_to(batch["inputs"], model.device),
"inputs": move_to(batch["inputs"], device),
"log_freq": 100,
},
}
Expand All @@ -82,7 +84,7 @@ def visualize_gt(self, train_batch, val_batch, iters):
LOGGER.text("Visualizing dataset...", level=LoggerObserver.DEBUG)

# Train batch
images = train_batch["inputs"]
images = train_batch["inputs"].cpu()

batch = []
for idx, inputs in enumerate(images):
Expand All @@ -107,7 +109,7 @@ def visualize_gt(self, train_batch, val_batch, iters):
)

# Validation batch
images = val_batch["inputs"]
images = val_batch["inputs"].cpu()

batch = []
for idx, inputs in enumerate(images):
Expand Down Expand Up @@ -162,12 +164,13 @@ def on_validation_end(self, trainer: pl.Trainer, pl_module: pl.LightningModule):
# Vizualize model predictions
LOGGER.text("Visualizing model predictions...", level=LoggerObserver.DEBUG)

images = last_batch["inputs"]
images = last_batch["inputs"].cpu()
targets = last_batch["targets"]
model.eval()
device = next(model.parameters()).device

## Get prediction on last batch
outputs = model.model.get_prediction(last_batch, device=model.device)
outputs = model.get_prediction(last_batch, device=device)
label_indices = outputs["labels"]
scores = outputs["confidences"]

Expand Down
4 changes: 2 additions & 2 deletions theseus/cv/classification/metrics/errorcases.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ def update(self, outputs: Dict[str, Any], batch: Dict[str, Any]):
targets = targets.squeeze(-1).long()

outputs = outputs.numpy().tolist()
targets = targets.numpy().tolist()
targets = targets.cpu().numpy().tolist()
probs = probs.numpy().tolist()

for (output, target, prob, image) in zip(outputs, targets, probs, images):
if output != target:
self.images.append(image)
self.images.append(image.cpu())
self.preds.append(output)
self.targets.append(target)
self.probs.append(prob)
Expand Down
Loading