Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Qt built-in icons for notification widget messages #143

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

copysent
Copy link

@copysent copysent commented Jul 2, 2024

Icons for messages do
not appear in the
notifications widget
if the icons do not
exist. This error
is present when using
the linuxcnc debian
image.
This commit changes
the icons to the
built-in Qt icons
instead.

This code will need to be tested to verify that it works as expected.

Icons for messages do
not appear in the
notifications widget
if the icons do not
exist. This error
is present when using
the linuxcnc debian
image.
This commit changes
the icons to the
built-in Qt icons
instead.
@TurBoss
Copy link
Member

TurBoss commented Jul 2, 2024

Hello!

I'm goin to test it

thank you!

@TurBoss
Copy link
Member

TurBoss commented Jul 2, 2024

I'm seen this

imagen
imagen
imagen
imagen

is this what you tried?

thanks

@copysent
Copy link
Author

copysent commented Jul 5, 2024

I'm seen this

imagen imagen imagen imagen

is this what you tried?

thanks

Yes and no. We have two installed OS images running a QtPyVcp custom VCP. One is Armbian and shows the icons as pictured. The other is debian (the official linuxcnc OS image) and the icons do not show in the official image.
The icon files dialog-information, etc are not present in any icon theme index file present in the debian based linuxcnc installation

@TurBoss
Copy link
Member

TurBoss commented Jul 5, 2024

hello, have you tried running qcompile . in bot qtpyvcp and your VCP directories?

I'm taking a look if debian need qticons something to be install because my test system is a debian 12 where i took the screenshots

@copysent
Copy link
Author

copysent commented Jul 8, 2024

python3-qtpyvcp/stable,now 4.1.2 all [installed]

I am using QtPyVcp from debian's package repositories. If qcompile needs to be run, my guess is it's something a package maintainer might be interested in.

@copysent
Copy link
Author

copysent commented Jul 8, 2024

hello, have you tried running qcompile . in bot qtpyvcp and your VCP directories?

I'm taking a look if debian need qticons something to be install because my test system is a debian 12 where i took the screenshots

If you have installed the linuxcnc debian os image and then installed KDE or Gnome afterwards, that might have pulled in additional icons that aren't there by default.

@TurBoss
Copy link
Member

TurBoss commented Jul 15, 2024

hello, sorry for the late reply

yes, qcompile is ran by buildbot when building debs so no need to run it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants