Remove defer function again and enable next one

Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
kcp-dev · Nov 5, 2024 · 59a7301 · 59a7301
1 parent 1193893
commit 59a7301
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/cmd/sharded-test-server/frontproxy.go b/cmd/sharded-test-server/frontproxy.go
@@ -157,12 +157,12 @@ func startFrontProxy(
 		return err
 	}
 
-	//defer func() {
-	//	err = logFile.Close()
-	//	if err != nil {
-	//		logger.Error(err, "failed to close the log file")
-	//	}
-	//}()
+	// defer func() {
+	// 	err = logFile.Close()
+	// 	if err != nil {
+	// 		logger.Error(err, "failed to close the log file")
+	// 	}
+	// }()
 
 	writer := helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = writer

diff --git a/cmd/sharded-test-server/virtual.go b/cmd/sharded-test-server/virtual.go
@@ -209,13 +209,13 @@ func (v *VirtualWorkspace) start(ctx context.Context) error {
 		return err
 	}
 
-	logger := klog.FromContext(ctx)
-	defer func() {
-		err = logFile.Close()
-		if err != nil {
-			logger.Error(err, "failed to close the log file")
-		}
-	}()
+	// logger := klog.FromContext(ctx)
+	// defer func() {
+	// 	err = logFile.Close()
+	// 	if err != nil {
+	// 		logger.Error(err, "failed to close the log file")
+	// 	}
+	// }()
 
 	v.writer = helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = v.writer

diff --git a/cmd/test-server/kcp/shard.go b/cmd/test-server/kcp/shard.go
@@ -117,12 +117,12 @@ func (s *Shard) Start(ctx context.Context, quiet bool) error {
 		return err
 	}
 
-	// defer func() {
-	// 	err = logFile.Close()
-	// 	if err != nil {
-	// 		logger.Error(err, "failed to close the log file")
-	// 	}
-	// }()
+	defer func() {
+		err = logFile.Close()
+		if err != nil {
+			logger.Error(err, "failed to close the log file")
+		}
+	}()
 
 	s.writer = helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = s.writer