Fix possible leak

Not closing os.File must not, but may lead to a leak. It is better to close it manually instead of waiting for the next GC to be triggered

Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>

cmd/sharded-test-server/cache.go

@@ -73,6 +73,13 @@ func startCacheServer(ctx context.Context, logDirPath, workingDir string, synthe
 		return nil, "", err
 	}
 
+	defer func() {
+		err = logFile.Close()
+		if err != nil {
+			klog.ErrorS(err, "failed to close the log file")
+		}
+	}()
+
 	writer := helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = writer
 	cmd.Stdin = os.Stdin

cmd/sharded-test-server/frontproxy.go

@@ -157,6 +157,13 @@ func startFrontProxy(
 		return err
 	}
 
+	defer func() {
+		err = logFile.Close()
+		if err != nil {
+			klog.ErrorS(err, "failed to close the log file")
+		}
+	}()
+
 	writer := helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = writer
 	cmd.Stdin = os.Stdin

cmd/sharded-test-server/virtual.go

@@ -209,6 +209,13 @@ func (v *VirtualWorkspace) start(ctx context.Context) error {
 		return err
 	}
 
+	defer func() {
+		err = logFile.Close()
+		if err != nil {
+			klog.ErrorS(err, "failed to close the log file")
+		}
+	}()
+
 	v.writer = helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = v.writer
 	cmd.Stdin = os.Stdin

cmd/test-server/kcp/shard.go

@@ -117,6 +117,13 @@ func (s *Shard) Start(ctx context.Context, quiet bool) error {
 		return err
 	}
 
+	defer func() {
+		err = logFile.Close()
+		if err != nil {
+			klog.ErrorS(err, "failed to close the log file")
+		}
+	}()
+
 	s.writer = helpers.NewHeadWriter(logFile, out)
 	cmd.Stdout = s.writer
 	cmd.Stdin = os.Stdin