🐛 Fix undo function of cluster annotation setter wiping annotations

[ntnn]

Summary

The undo function of the admission webhook wiped annotations if the cluster annotation was not present.

Related issue(s)

Fixes #3182 introduced in #3124

Release Notes

Fix external modifications to annotations being reverted by admission webhook

[kcp-ci-bot]

Hi @ntnn. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[embik]

/ok-to-test

Thank you for the contribution @ntnn! Can you please also add a release note to the PR description (something like "Stop removing annotations added by mutating webhooks" that describes what is fixed here)?

[ntnn]

/retest

[mjudeikis]

/lgtm
/approve

thanks for this!

[kcp-ci-bot]

LGTM label has been added.

Git tree hash: 20f7a5ad321b50c0f98989b8049fce57a4545174

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/admission/OWNERS [mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment